Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] slow frame in new gallery while navigating to travel application #147797

Closed
jonahwilliams opened this issue May 3, 2024 · 1 comment · Fixed by #147882
Closed

[Impeller] slow frame in new gallery while navigating to travel application #147797

jonahwilliams opened this issue May 3, 2024 · 1 comment · Fixed by #147882
Assignees
@jonahwilliams
Labels
e: impeller Impeller rendering backend issues and features requests P1 High-priority issues at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@jonahwilliams
Copy link
Member

image

Theories:

  • Images are too big
  • Too many images
  • glyph atlas reconstruction is expensive and might be unnecessary (or could be allocation).
@jonahwilliams jonahwilliams added P1 High-priority issues at the top of the work list e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team labels May 3, 2024
@jonahwilliams jonahwilliams self-assigned this May 3, 2024
@jonahwilliams
Copy link
Member Author

Yup, they're too big:

Another exception was thrown: Image packages/flutter_gallery_assets/assets/studies/3.0x/crane_card_dark.png has a display size of 777×546 but a decode size of 888×600,
which uses an additional 565KB (assuming a device pixel ratio of 2.625).
W/WindowOnBackDispatcher( 7767): OnBackInvokedCallback is not enabled for the application.
W/WindowOnBackDispatcher( 7767): Set 'android:enableOnBackInvokedCallback="true"' in the application manifest.
Another exception was thrown: Image packages/flutter_gallery_assets/assets/studies/3.0x/crane_card_dark.png has a display size of 777×546 but a decode size of 888×600,
which uses an additional 565KB (assuming a device pixel ratio of 2.625).
Another exception was thrown: Image packages/flutter_gallery_assets/assets/studies/3.0x/rally_card_dark.png has a display size of 777×546 but a decode size of 888×600,
which uses an additional 565KB (assuming a device pixel ratio of 2.625).
Another exception was thrown: Image packages/flutter_gallery_assets/assets/studies/3.0x/crane_card_dark.png has a display size of 777×546 but a decode size of 888×600,
which uses an additional 565KB (assuming a device pixel ratio of 2.625).
Another exception was thrown: Image packages/flutter_gallery_assets/crane/destinations/3.0x/fly_0.jpg has a display size of 157×147 but a decode size of 1200×1200, which
uses an additional 7379KB (assuming a device pixel ratio of 2.625).
Another exception was thrown: Image packages/flutter_gallery_assets/crane/destinations/3.0x/fly_1.jpg has a display size of 157×147 but a decode size of 1200×1230, which
uses an additional 7566KB (assuming a device pixel ratio of 2.625).
Another exception was thrown: Image packages/flutter_gallery_assets/crane/destinations/3.0x/fly_3.jpg has a display size of 157×147 but a decode size of 1200×1131, which
uses an additional 6948KB (assuming a device pixel ratio of 2.625).
Another exception was thrown: Image packages/flutter_gallery_assets/crane/destinations/3.0x/fly_2.jpg has a display size of 157×147 but a decode size of 1200×1182, which
uses an additional 7266KB (assuming a device pixel ratio of 2.625).
Another exception was thrown: Image packages/flutter_gallery_assets/crane/destinations/3.0x/fly_4.jpg has a display size of 157×147 but a decode size of 1200×924, which
uses an additional 5654KB (assuming a device pixel ratio of 2.625).

Thumbnails people!

@jonahwilliams jonahwilliams added the triaged-engine Triaged by Engine team label May 6, 2024
@jonahwilliams jonahwilliams mentioned this issue May 6, 2024
Merged
auto-submit bot pushed a commit that referenced this issue May 6, 2024
@jonahwilliams
[new gallery] Reisze gallery images (#147882)
5230ec5 
Some cause of jank on both Skia and Impeller are these massive images. We should just resize them so that the noise is reduced and we can see other performance issues.

Fixes #147797

Tested: this is a test!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonahwilliams jonahwilliams

Labels
e: impeller Impeller rendering backend issues and features requests P1 High-priority issues at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[new gallery] Reisze gallery images jonahwilliams/flutter
1 participant
@jonahwilliams