New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Slider
for Material 3 redesign
#141842
Comments
Slider
for Material 3 redesign
cc: @HansMuller @Piinks I'll be more than happy to take this when we decide to work on this. |
As always, you're our hero @TahaTesser! I think this change will be a bit controversial over the original slider due to its size, so decent configuration options are probably worthwhile. However, the new style defaults fit in a lot better with other new styles like the switches and it has a lot of accessibility wins, so I'm excited for this. Thanks 💙 |
Creating a new component vs evolving the existing one is a tricky question; there are many pros and cons to consider. Either way, it's a big project. We'll need to think carefully about how (and when) to proceed. |
In general, introducing new widgets instead of updating old ones is the most disruptive and breaking change for developers. |
I have no particular preference, I was just enumerating some possibilities for discussion. Whatever is the standard for the framework and less disruptive for developers works for me :) |
Isn't it the other way around? After the old widget is updated, all projects using it will need to update the code to restore the desired results. In the case of creating a new widget, nothing will break for anyone, they will only have the opportunity to use the new widget if they want. |
There isn't a way for the framework to differentiate between the users who want Material Design and those who use For developers who want "native" Material Design like on Android, updating the existing slider would be better. The rest would prefer introducing a new widget, so that they don't need to update their hacks that make the Material widget match their design teams' Figma. At the core of this is the unresolved "ship material as a seperate package" issue, which would make it much easier to stay on older versions of the package, while at the same time keeping the Flutter version fresh -- and the blankcanvas / shadcn projects that aim to provide actually neutral components that are ment to be customized. |
@guidezpl |
@guidezpl just sent me the code, I can take a look, add tests, docs, example and update Slider in a non-breaking way. Thanks! |
I made a bunch of bug fixes and improvements to the thumb and track code provided by @guidezpl Today I created the new value indicator shape to go with this update. This is almost done, more tweaks and tests are needed, will file this next week. |
Thank you @TahaTesser for implementing this cool redesign. In this new material redesign has been added also the "centered configuration" Will your PR also add this feature or will it be added later? Thank you! |
M3 sliders have an updated look
Since this occurred after the primary Material 3 transition, this could potentially be an option that starts as defaulting to
false
, switches totrue
, and then is eventually removed. Or a new widget as they are significantly different.Specification: https://m3.material.io/components/sliders/specs
December 2023 updates: https://m3.material.io/components/sliders/overview#79de9466-a59c-4236-9099-735e67a38e53
The text was updated successfully, but these errors were encountered: