Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURES] pod Label fluid.io/enable-injection missing should be treated same as fluid.io/enable-injection=false #3679

Open
kingeasternsun opened this issue Jan 4, 2024 · 1 comment
Labels
features features

Comments

@kingeasternsun
Copy link

What feature you'd like to add:

When CreateUpdatePodForSchedulingHandler Handle pod, should treats pod without Label fluid.io/enable-injection same as pod with fluid.io/enable-injection=false,just skip mutating the pod

Why is this feature needed:
In the k8s clusters of many companies, there are many other services that do not require fluid.
If CreateUpdatePodForSchedulingHandler could treats pod without Label fluid.io/enable-injection same as pod with Labelfluid.io/enable-injection=false, these services could continue work without the need for additional modifications that add labels fluid.io/enable-injection=false to the pod of services

@kingeasternsun kingeasternsun added the features features label Jan 4, 2024
@TrafalgarZZZ
Copy link
Member

@kingeasternsun Thanks for the issue. Which version of Fluid are you using? We have now turned to use objectSelector instead of the namespaceSelector``fluid.io/enable-injection. You can trigger webhook mutations at pod-level with pod.metadata.labels={"fuse.serverful.fluid.io/inject": "true"} or pod.metadata.labels={"serverless.fluid.io/inject": "true"}. Please see here and here for detailed examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features features
Projects
None yet
Development

No branches or pull requests

2 participants