Add support for `Satisfy` on `ReferenceTypeAssertions` #2597

siewers · 2024-02-29T19:59:05Z

Added support for Satisfy on ReferenceTypeAssertions allowing to use element inspectors as an alternative to using predicates on Match.

Example:

var myDto = new Dto { Name = "Some Name" };

myDto.Should().Satisfy<Dto>(dto => dto.Name.Should().Be("Some Name"));

Fixed #2516

IMPORTANT

If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
The code complies with the Coding Guidelines for C#.
The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
- Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

github-actions · 2024-02-29T20:04:09Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

Tests/FluentAssertions.Specs/Primitives/ReferenceTypeAssertionsSpecs.Satisfy.cs

ITaluone · 2024-03-01T06:03:30Z

Missing release notes?

siewers · 2024-03-01T08:33:09Z

I didn't add it to the release notes yet as I'm unsure what version this will be in.

@dennisdoomen I can see that we're at Alpha 3 now, but the release notes only contain Alpha 1. I've added the changes to the current section of the releases.md, but I think something might be wrong. Can you let me know if I need to change something?

ITaluone · 2024-03-01T09:33:38Z

I didn't add it to the release notes yet as I'm unsure what version this will be in.

I think while on develop for the next version it doesn't really matter

siewers · 2024-03-01T09:41:12Z

@ITaluone Alright, I added it the the most recent section. I guess it will be aligned when the final release goes out, however, it might be a bit confusing for people using the Alpha versions to see the release notes not reflecting the latest version.

siewers · 2024-03-01T10:08:01Z

@dennisdoomen @ITaluone I believe I've addressed all comments now.

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs

docs/_pages/basicassertions.md

docs/_pages/releases.md

coveralls · 2024-03-11T07:50:34Z

Pull Request Test Coverage Report for Build 9436657769

Details

22 of 22 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 97.577%

Totals
Change from base Build 9428450907:	0.01%
Covered Lines:	12078
Relevant Lines:	12261

💛 - Coveralls

dennisdoomen · 2024-03-11T08:50:06Z

I believe I've addressed all comments now.

Apparently not.

ITaluone · 2024-03-12T09:42:49Z

@siewers Could you rebase to current develop and force push again?

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs

dennisdoomen · 2024-03-17T20:14:51Z

Did you close it on purpose?

siewers · 2024-03-17T20:17:11Z

Wow, no, I didn't... I don't know what happened.

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs

siewers · 2024-05-12T09:21:45Z

@dennisdoomen I see you approved this PR, but it's blocked by a couple of checks. Is there anything further on my part I need to take care of?

IT-VBFK · 2024-05-12T12:45:35Z

Rebase to current develop and force push

github-actions · 2024-05-14T17:23:23Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

ITaluone · 2024-05-16T15:22:03Z

@siewers To fix the current problems rebase again :)

siewers · 2024-05-23T07:50:35Z

I've rebased, and all checks are passing. Can we merge this?

dennisdoomen · 2024-05-23T10:07:10Z

I've rebased, and all checks are passing. Can we merge this?

Waiting for a review from @jnyrup

…spectors

Co-authored-by: Dennis Doomen <[email protected]>

siewers mentioned this pull request Feb 29, 2024

Allow Should().Satisfy() on objects and not only collections #2516

Closed

ITaluone reviewed Mar 1, 2024

View reviewed changes

Tests/FluentAssertions.Specs/Primitives/ReferenceTypeAssertionsSpecs.Satisfy.cs Outdated Show resolved Hide resolved

siewers force-pushed the develop branch from c330735 to 0161483 Compare March 1, 2024 08:34

dennisdoomen reviewed Mar 2, 2024

View reviewed changes

siewers force-pushed the develop branch 2 times, most recently from 84bfdf1 to a7be412 Compare March 12, 2024 13:44

IT-VBFK reviewed Mar 12, 2024

View reviewed changes

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs Show resolved Hide resolved

siewers closed this Mar 17, 2024

dennisdoomen mentioned this pull request Mar 17, 2024

Allow nested AssertionScopes to chain their context #2607

Merged

7 tasks

siewers reopened this Mar 17, 2024

jnyrup reviewed Mar 24, 2024

View reviewed changes

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs Outdated Show resolved Hide resolved

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs Outdated Show resolved Hide resolved

siewers force-pushed the develop branch from a6b5b8c to 528af7d Compare March 24, 2024 19:48

jnyrup mentioned this pull request Apr 10, 2024

[API Proposal]: Allow to assert RegEx matched groups #2625

Open

jnyrup reviewed Apr 10, 2024

View reviewed changes

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs Show resolved Hide resolved

dennisdoomen approved these changes May 10, 2024

View reviewed changes

siewers force-pushed the develop branch from 528af7d to 1d6c891 Compare May 14, 2024 17:14

siewers force-pushed the develop branch from 1d6c891 to e7b09c3 Compare May 16, 2024 20:02

jnyrup changed the title ~~Add support for Satisfy on ReferenceTypeAssertions~~ Add support for Satisfy on ReferenceTypeAssertions May 27, 2024

siewers force-pushed the develop branch from c132f40 to e7b09c3 Compare June 9, 2024 09:16

siewers and others added 13 commits June 9, 2024 11:17

Add support for Satisfy on reference type assertions using element in…

1406c08

…spectors

Combine Act and Assert in tests that should not throw

d3051da

Reorganize and add additional test for complex object not throwing

a037484

Update release notes

3e1da18

Update tests to follow guidelines

a2517cd

Add tests asserting derived types

e4bbf68

Use date extensions in assertions

156b23f

Rephrase release notes

34c28d9

Co-authored-by: Dennis Doomen <[email protected]>

Rephrase XML documentation

e9fd5e4

Fix documentation layout

c9e4828

Approve API

50816d3

Check subject for null

830e589

Ensure preconditions are met

ba8c369

siewers force-pushed the develop branch from e7b09c3 to ba8c369 Compare June 9, 2024 09:21

Do not throw NRE if Subject is null inside type compatibility check

2a536ac

jnyrup approved these changes Jun 9, 2024

View reviewed changes

Update tests

3e30035

dennisdoomen merged commit 418a327 into fluentassertions:develop Jun 10, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for `Satisfy` on `ReferenceTypeAssertions` #2597

Add support for `Satisfy` on `ReferenceTypeAssertions` #2597

siewers commented Feb 29, 2024 •

edited by jnyrup

github-actions bot commented Feb 29, 2024 •

edited

ITaluone commented Mar 1, 2024

siewers commented Mar 1, 2024 •

edited

ITaluone commented Mar 1, 2024

siewers commented Mar 1, 2024

siewers commented Mar 1, 2024

coveralls commented Mar 11, 2024 •

edited

dennisdoomen commented Mar 11, 2024

ITaluone commented Mar 12, 2024

dennisdoomen commented Mar 17, 2024

siewers commented Mar 17, 2024

siewers commented May 12, 2024

IT-VBFK commented May 12, 2024

github-actions bot commented May 14, 2024 •

edited

ITaluone commented May 16, 2024

siewers commented May 23, 2024

dennisdoomen commented May 23, 2024

Add support for Satisfy on ReferenceTypeAssertions #2597

Add support for Satisfy on ReferenceTypeAssertions #2597

Conversation

siewers commented Feb 29, 2024 • edited by jnyrup

IMPORTANT

github-actions bot commented Feb 29, 2024 • edited

Qodana for .NET

ITaluone commented Mar 1, 2024

siewers commented Mar 1, 2024 • edited

ITaluone commented Mar 1, 2024

siewers commented Mar 1, 2024

siewers commented Mar 1, 2024

coveralls commented Mar 11, 2024 • edited

Pull Request Test Coverage Report for Build 9436657769

Details

💛 - Coveralls

dennisdoomen commented Mar 11, 2024

ITaluone commented Mar 12, 2024

dennisdoomen commented Mar 17, 2024

siewers commented Mar 17, 2024

siewers commented May 12, 2024

IT-VBFK commented May 12, 2024

github-actions bot commented May 14, 2024 • edited

Qodana for .NET

ITaluone commented May 16, 2024

siewers commented May 23, 2024

dennisdoomen commented May 23, 2024

Add support for `Satisfy` on `ReferenceTypeAssertions` #2597

Add support for `Satisfy` on `ReferenceTypeAssertions` #2597

siewers commented Feb 29, 2024 •

edited by jnyrup

github-actions bot commented Feb 29, 2024 •

edited

siewers commented Mar 1, 2024 •

edited

coveralls commented Mar 11, 2024 •

edited

github-actions bot commented May 14, 2024 •

edited