Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host identifiers in the docs, CLI and API are confusing and not well defined #19127

Open
roperzh opened this issue May 17, 2024 · 2 comments
Open
Assignees
Labels
~dogfood Issue resulted from Fleet's product dogfooding. #g-mdm MDM product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature

Comments

@roperzh
Copy link
Member

roperzh commented May 17, 2024

Problem

As an IT admin or security admin trying to interact with the Fleet CLI and API, the documentation in fleetctl and the API docs is not clear when it comes to "host identifiers"

Host identifier is described in the errors and docs as: a valid hostname, UUID, osquery host ID, or node key.

Some of the problems:

  • When you go to the UI, we have two columns:Host and Hostname, people generally grab the value from Host and get an error.
  • Many people would expect to be able to provide a host id as well in this endpoint
  • Some values have confusing names and are not explained as part of the error, eg: what's a "node key"?

Potential solutions

  • Improve our error messages, potentially including a link to the docs where each possible field is described
  • Improve the API docs
  • Not sure how to prevent people from tripping in the Host vs Hostname debacle
@roperzh roperzh added :product Product Design department (shows up on 🦢 Drafting board) ~feature fest Will be reviewed at next Feature Fest labels May 17, 2024
@roperzh roperzh changed the title host identifiers in the docs, CLI and API is confusing and not well defined host identifiers in the docs, CLI and API are confusing and not well defined May 17, 2024
@noahtalerman
Copy link
Member

Thanks for tracking this @roperzh!

I think improving the error message would be a great, quick win.

What do you think the error message should be?

@noahtalerman noahtalerman removed the :product Product Design department (shows up on 🦢 Drafting board) label May 20, 2024
@noahtalerman noahtalerman added the ~dogfood Issue resulted from Fleet's product dogfooding. label May 28, 2024
@noahtalerman
Copy link
Member

Host identifier is described in the errors and docs as: a valid hostname, UUID, osquery host ID, or node key.

Seems like a quick win here would be improving the error message and the Get host by identifier docs: https://fleetdm.com/docs/rest-api/rest-api#get-host-by-identifier

@noahtalerman noahtalerman assigned roperzh and marko-lisica and unassigned roperzh May 30, 2024
@noahtalerman noahtalerman added #g-mdm MDM product group story A user story defining an entire feature :product Product Design department (shows up on 🦢 Drafting board) and removed ~feature fest Will be reviewed at next Feature Fest labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~dogfood Issue resulted from Fleet's product dogfooding. #g-mdm MDM product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature
Development

No branches or pull requests

3 participants