Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear how often policy pass/fail counts update #19083

Closed
lukeheath opened this issue May 16, 2024 · 8 comments
Closed

Unclear how often policy pass/fail counts update #19083

lukeheath opened this issue May 16, 2024 · 8 comments
Labels
~dogfood Issue resulted from Fleet's product dogfooding. story A user story defining an entire feature

Comments

@lukeheath
Copy link
Member

Fleet version: 4.49.3

Web browser and operating system: Chrome

💥  Actual behavior

A policy count shows 2 failing hosts ("macOS - Check if latest version"), but when I click the link, I see 25 hosts that are listed as showing. If we know the 25 failing hosts, we should update the policy count. It did eventually update.

🧑‍💻  Steps to reproduce

  1. Create a new "macOS - Check if latest version" policy.
  2. Wait for initial results.
  3. Click on the host count and see that the filtered list of hosts does not match the host count.

🕯️ More info (optional)

N/A
@lukeheath lukeheath added bug Something isn't working as documented ~released bug This bug was found in a stable release. #g-endpoint-ops Endpoint ops product group :incoming New issue in triage process. labels May 16, 2024
@sharon-fdm sharon-fdm added the :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. label May 17, 2024
@lukeheath lukeheath added this to the 4.51.0-tentative milestone May 22, 2024
@sharon-fdm sharon-fdm removed their assignment May 22, 2024
@jacobshandling jacobshandling added the ~backend Backend-related issue. label May 22, 2024
@sharon-fdm
Copy link
Contributor

sharon-fdm commented May 22, 2024 •
edited

@lukeheath by design the cron job that updates the total number runs every 1H.
We could implement some UI coding that will collect the current status (Or do the same in BE) but that will be a feature request.

If still required, we can make it a story. In such case we'll need product to describe how to solve it. (e.g. UI will count current failing hosts, or more frequent cron jobs etc)

@sharon-fdm sharon-fdm added story A user story defining an entire feature and removed bug Something isn't working as documented :incoming New issue in triage process. labels May 22, 2024
@sharon-fdm sharon-fdm added :product Product Design department (shows up on 🦢 Drafting board) and removed :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. labels May 22, 2024
@noahtalerman
Copy link
Member

the cron job that updates the total number runs every 1H.

@lukeheath here's the issue where we made this change: #13574

I think 1 hr is for customers with a large number of policies and hosts. We could crank it down in dogfood.

But, I don't think this job's frequency is configurable. @mostlikelee please correct me if I'm wrong.

Maybe that's the feature request: making this job configurable.

@noahtalerman noahtalerman removed the :product Product Design department (shows up on 🦢 Drafting board) label May 23, 2024
@noahtalerman noahtalerman added :product Product Design department (shows up on 🦢 Drafting board) ~dogfood Issue resulted from Fleet's product dogfooding. and removed ~backend Backend-related issue. ~released bug This bug was found in a stable release. #g-endpoint-ops Endpoint ops product group labels May 23, 2024
@mostlikelee
Copy link
Contributor

But, I don't think this job's frequency is configurable. @mostlikelee please correct me if I'm wrong.

That's correct. We could also consider defaulting smaller environments to calculate counts on demand. The original issue is that the request/page load would take a very long time with large amounts of hosts and policies.

@noahtalerman
Copy link
Member

Thanks Tim!

Moving this one to feature fest.

@noahtalerman noahtalerman removed their assignment May 30, 2024
@noahtalerman noahtalerman added ~feature fest Will be reviewed at next Feature Fest and removed :product Product Design department (shows up on 🦢 Drafting board) labels May 30, 2024
@noahtalerman noahtalerman changed the title Delay in updating policy pass/fail counts Unclear how often policy pass/fail counts update May 30, 2024
@noahtalerman noahtalerman removed this from the 4.51.0-tentative milestone May 31, 2024
@rachaelshaw
Copy link
Member

@lukeheath we added this tooltip a few months ago, does this solve it or do you think that info needs to be more prominent?

Screenshot 2024-05-31 at 10 12 58 AM

@noahtalerman
Copy link
Member

Removing from feature fest for now. @lukeheath please feel free to bring it back.

@noahtalerman noahtalerman removed the ~feature fest Will be reviewed at next Feature Fest label May 31, 2024
@lukeheath
Copy link
Member Author

@rachaelshaw Thanks, I think the tooltip addresses this issue. Closing.

@fleet-release
Copy link
Contributor

Policy counts in sync,
Like leaves aligned in the breeze.
Clarity takes root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
~dogfood Issue resulted from Fleet's product dogfooding. story A user story defining an entire feature
Milestone
No milestone
Development

No branches or pull requests
7 participants
@lukeheath @rachaelshaw @mostlikelee @noahtalerman @jacobshandling @fleet-release @sharon-fdm