Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add software counts to Fleet usage statistics #19072

Open
lucasmrod opened this issue May 16, 2024 · 3 comments
Open

Add software counts to Fleet usage statistics #19072

lucasmrod opened this issue May 16, 2024 · 3 comments
Assignees
Labels
~backend Backend-related issue. ~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~usage-statistics Relates to Fleet's usage statistics.
Milestone

Comments

@lucasmrod
Copy link
Member

lucasmrod commented May 16, 2024

Why

We'd like our (simulated) loadtest environments to be as close to reality as possible.
We need information of software counts with respect to host counts. (We currently don't have this information)

What

We'd like to collect the following stats from Fleet users:

  • Number of rows in software table.
  • Number of rows in host_software table.
  • Number of rows in software_titles table.
  • Number of rows in host_software_installed_paths table.
  • Number of rows in software_cpe.
  • Number of rows in software_cve.

They should be added here:

func (ds *Datastore) ShouldSendStatistics(ctx context.Context, frequency time.Duration, config config.FleetConfig) (fleet.StatisticsPayload, bool, error) {

Next steps

After collecting this information, we need to update osquery-perf agents to reflect the software/host_software counts. In addition, we also need to lower the % of failing to fetch software from 50% to something more realistic like 5% or lower.

@lucasmrod lucasmrod added ~backend Backend-related issue. ~usage-statistics Relates to Fleet's usage statistics. :product Product Design department (shows up on 🦢 Drafting board) ~feature fest Will be reviewed at next Feature Fest labels May 16, 2024
@lucasmrod lucasmrod added the ~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. label May 16, 2024
@noahtalerman
Copy link
Member

@lucasmrod makes sense.

I think this issue meets the definition of ~engineering-initiated so it can go through the eng-initiated prioritization process instead of feature fest.

Pulling this off the feature fest board.

cc @lukeheath

@noahtalerman noahtalerman removed :product Product Design department (shows up on 🦢 Drafting board) ~feature fest Will be reviewed at next Feature Fest labels May 17, 2024
@lucasmrod lucasmrod added the #g-endpoint-ops Endpoint ops product group label May 17, 2024
@sharon-fdm
Copy link
Contributor

@lukeheath @noahtalerman @lucasmrod I actually have a very similar PR for that from the hackathon. (minor adaptations)
#19078

@sharon-fdm sharon-fdm added :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. and removed :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. labels May 17, 2024
@lukeheath lukeheath added the :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. label May 17, 2024
@lukeheath lukeheath added this to the 4.51.0-tentative milestone May 22, 2024
@sharon-fdm
Copy link
Contributor

FYI @eashaw, These metrics should be reported starting the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~backend Backend-related issue. ~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~usage-statistics Relates to Fleet's usage statistics.
Development

No branches or pull requests

4 participants