Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionFailureMode #374

Open
moshloop opened this issue Nov 18, 2021 · 3 comments · May be fixed by #863 or #1813
Open

ConnectionFailureMode #374

moshloop opened this issue Nov 18, 2021 · 3 comments · May be fixed by #863 or #1813
Assignees
@adityathebe
Labels
bug Something isn't working
Milestone
v1.0.0

Comments

@moshloop
Copy link
Member

moshloop commented Nov 18, 2021 •
edited

  • Failed (don't run exprs)
  • Invalid (+ fire different event, don't run exprs)
    • don't include status in lastResult function
    • check status become invalid
  • Continue (run exprs to determine status)
@moshloop moshloop added the bug Something isn't working label Nov 18, 2021
@yashmehrotra
Copy link
Member

If check fails, templating should not run

@yashmehrotra yashmehrotra linked a pull request Mar 15, 2023 that will close this issue
Open
@moshloop moshloop added this to the v1.0.0 milestone Mar 20, 2023
@moshloop
Copy link
Member Author 


test:
     expr: error == null && status.code > 399

@moshloop moshloop changed the title Prometheus - When query fails, templates error out ConnectionFailureMode Mar 21, 2024
@moshloop moshloop assigned adityathebe and unassigned yashmehrotra Mar 27, 2024
@adityathebe adityathebe linked a pull request Apr 29, 2024 that will close this issue
Open
@adityathebe
Copy link
Member

adityathebe commented Apr 29, 2024 •
edited 

test:
     expr: error == null && status.code > 399

If we don't run expression when the check errors out, do we need the error == null check in expr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityathebe adityathebe

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0.0
3 participants
@moshloop @yashmehrotra @adityathebe