Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoClose is not respected when manually setting progress to 1 #1116

Open
danny-does-stuff opened this issue May 16, 2024 · 0 comments
Open

Comments

@danny-does-stuff
Copy link

danny-does-stuff commented May 16, 2024

Do you want to request a feature or report a bug?
Report a bug

What is the current behavior?
When manually setting progress to 1 via toast.update(toastId, { progress: 1 }), the toast auto closes even when autoClose: false is set.

Steps to Reproduce + Repro:

  1. Create a toast that should not auto close using const toastId = toast('your message', { autoClose: false })
  2. update the toast's progress manually using toast.update(toastId, { progress: 1 })
  3. See the toast autoclose :(

CodeSandbox: https://codesandbox.io/p/sandbox/react-toastify-autoclose-with-progress-n5d5jg

What is the expected behavior?
If I use autoClose: false, then the toast should not close automatically

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React 18, chromium based browser on Mac. I'm uncertain how this behaves on old versions of React

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant