Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove #299

Open
github-actions bot opened this issue Jan 9, 2024 · 3 comments
Open

remove #299

github-actions bot opened this issue Jan 9, 2024 · 3 comments
Assignees
Labels
code:todo A TODO/FIXME comment in code.

Comments

@github-actions
Copy link

github-actions bot commented Jan 9, 2024

/// Search for game with `matchmaking_server` and `player_count`
pub fn start_search_for_game(matchmaking_server: String, player_count: usize) {
// TODO remove
info!("Starting search for online game with player count {player_count}");
ONLINE_MATCHMAKER
.try_send(OnlineMatchmakerRequest::SearchForGame {
addr: matchmaking_server.clone(),
player_count,


This issue was generated by todo-issue based on a TODO comment in 01823b4.
@github-actions github-actions bot added the code:todo A TODO/FIXME comment in code. label Jan 9, 2024
@MaxCWhitehead
Copy link
Collaborator

MaxCWhitehead commented Jan 16, 2024

lol @zicklag I need to be more careful about my TODO comments I guess, didn't know they'd open issues. Probably for the best as this way I actually will clean up the comments...

Feel free to assign any of these to me. (At least, the ones that are not real issues)

@erlend-sh
Copy link
Member

Maybe there's some place in our codebase/docs where we could clearly point out that we've got some special handling in place for TODO comments?

@zicklag
Copy link
Member

zicklag commented Jan 17, 2024

Yeah, we have a minor note about TODO comments in the README: https://github.com/fishfolk/bones?tab=readme-ov-file#contributing.

Honestly I probably should have caught this when I reviewed the code to prevent it from getting in in the first place. Either way, it's good that there are obvious so that we must go and remove them, I suppose. :)

@zicklag zicklag closed this as completed Jan 17, 2024
@zicklag zicklag reopened this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code:todo A TODO/FIXME comment in code.
Projects
None yet
Development

No branches or pull requests

3 participants