[Feature] bind command ensure-selection-start

[patrick-kidger]

Right now the bind command has its own sublanguage. In particular this has a way to swap the start and end of the selection, with swap-selection-start-stop.

It'd be great if there was a way to specify that it was specifically at the start or the stop. The reason I'd find this useful is because I'm putting together a Helix-mode for editing commands, as an alternative to the existing vi-mode. I'm proposing adding an ensure-selection-start command that ensures the cursor is specifically on the left end of the selection.

Poking around a bit, it looks like this should be doable by adding an entry to this table:

fish-shell/src/input.rs

Line 115 in 8667ed5

const INPUT_FUNCTION_METADATA: &[InputFunctionMetadata] = &[

and a short implementation in this file:

fish-shell/src/reader.rs

Line 1 in 8667ed5

//! Functions for reading data from stdin and passing to the parser. If stdin is a keyboard, it

Does this seem reasonable to you?

[cklim24]

Right now the bind command has its own sublanguage. In particular this has a way to swap the start and end of the selection, with swap-selection-start-stop.

It'd be great if there was a way to specify that it was specifically at the start or the stop. The reason I'd find this useful is because I'm putting together a Helix-mode for editing commands, as an alternative to the existing vi-mode. I'm proposing adding an ensure-selection-start command that ensures the cursor is specifically on the left end of the selection.

Poking around a bit, it looks like this should be doable by adding an entry to this table:

fish-shell/src/input.rs

Line 115 in 8667ed5

const INPUT_FUNCTION_METADATA: &[InputFunctionMetadata] = &[

and a short implementation in this file:

fish-shell/src/reader.rs

Line 1 in 8667ed5

//! Functions for reading data from stdin and passing to the parser. If stdin is a keyboard, it

Does this seem reasonable to you?

[faho]

@cklim24: You've now just quoted two separate posts. Do you have anything to say?

[krobelus]

yeah that sounds reasonable. Could probably also benefit https://github.com/sshilovsky/fish-helix