fish 3.7.0

[zanchey]

I've not used Discussions much, but let's give it a crack.

The Rust rewrite is well underway and it seems pretty clear that releasing a half-C++, half-Rust hybrid is an explicit non-goal.

If there are significant bugs in fish 3.6.1 that need to be fixed, we can produce a 3.6.2 release. As part of this, we can roll up minor
fixes, new and improved completions, and improvements to the documentation.

What I'm less sure on is whether it's worth planning a 3.6.2 (or call it a 3.7.0 branched from 3.6.1) in a few months with minor bugs, new completions, documentation improvements and any safe new features. We've traditionally avoided new features in point releases, just by necessity, but as we don't support anything except the latest branch I think it's probably effectively the same thing.

[faho]

As I see it, there are two separate reasons for making a 3.6.2/3.7.0:

Either we make it before the rust track is ready, because it's taking too long

or we make it because some users are having issues upgrading to the rust track and so we support them for a bit while they get their situation sorted.

For the first, I'm not sure how many features we'll even add - personally I've been holding back on doing any C++ work because I don't want to write things twice before they ever get used. So I guess we'll have to see how many important or easy bugs show up that we would want to backport the fixes for.

For the second, I've said before that we could do that but there would have to be interest. As I've seen it, most users should be able to build the rust version by just using rustup, so there is less of an argument than there was for sticking to C++11 (because upgrading C++ compilers is a PITA). So, for the most part, this would be targeting packagers.

In the past we've seen some packagers not upgrade even to patch releases (which is how e.g. 3.1.0 keeps turning up in bug reports), so I would like to see some interest in this before we waste our time.

(and if it's for packagers, it's probably okay to have it as a git tag only, I've seen that work for other projects - which would also mean no macos packages, which should ease releasing a bit)

[faho]

I have been tagging issues that would be okay for a bugfix 3.6.2: https://github.com/fish-shell/fish-shell/issues?q=is%3Aissue+milestone%3A%22fish+3.6.2%22

For now it's mostly completion fixes, together with a documentation improvement and a fix to the doc css - which isn't all that critical because it'll mostly be seen on mobile and I've updated the hosted version at fishshell.com.

A few of the 3.7.0 closed issues could also be added:

• Fish Running as Root Fails to Suggest All Executable Commands in PATH #9699 - fix $PATH search for root
• Exit with negative numbers causes assertion failure #9659 - fix exit with negative returns
• Add Fossil support to fish_vcs_prompt #9497 - fossil vcs prompt
• Add conda env create and conda env list completions #9452, completions
• fish_vi_key_bindings locks fish up in no-config mode #9443 - fish_vi_key_bindings in no-config mode
• Strange side effect of read #8285 - disable bracketed paste for read
• Using block cursor only for normal state? #4656 - an "external" cursor mode for vi-mode
• completion ignoring . prefixed arguments #3707 - don't ignore custom completions with leading "."

[faho]

#9814 is annoying - Python changed something in 3.12, and it prints warnings

[faho]

@zanchey Honestly I believe we have enough to warrant a 3.6.2, even just taking the 15 already fixed issues, which range from completion bugs (#9538, #9738, #9705) to a compatibility fix with python 3.12 (#9814).

I would also take at least #9699 and #9659 from the 3.7.0 issues.

[zanchey]

Yeah, let's do it.

[faho]

We should also add 7f76f75 and 1f19756. I neglected to open an issue for it, but it speeds up git add completions if you have a lot of untracked files by a factor of ~5-8x.

[zanchey]

I think we'll take most of those additional items, and call it 3.7.0.

[faho]

Alright, we're doing 3.7.0, and here's the commits I've picked so far:

• cf67709 feat: add support for fossil-scm in prompt #9500, fossil
• af49b4d Strange side effect of read #8285, bracketed paste for read
• a16abf2 Exit with negative numbers causes assertion failure #9659, exit with negative value
• ca02e88 Documentation is clipped on right side #9690, docs overflow for narrow screens
• 3a72d09 Use stack's dynamic completions #9681, stack completions
• ba77858 Add md-to-clip completion #9664, md-to-clip completions
• c39780f git --switch=... completion issues #9538, __fish_complete_directories to remove --foo=
• 563b4d2 git --switch=... completion issues #9538, git
• bc04abe git switch -c [TAB] completion does not work #9692, git
• e45bddc Vi mode cursor doesn't respect iTerm2 cursor settings #9698, ignore unknown cursor shapes
• 9bd1dc1 Add Zabbix completions #9647, zabbix completions
• c67d77f Fish Running as Root Fails to Suggest All Executable Commands in PATH #9699, fix command completions as root
• d671710 Document pipe, redirection, and semicolon properly. #5319, docs on pipes
• 85504ca completions: zfs completions broken due to read-only variable #9705, zfs completion error
• 0f1ef34 Fix adb path completion #9707, adb path
• b5bfff9 completions/mix: Add options for phx.new in 1.7.2 #9706, mix completions
• a6e16a1 docs/interactive: Document fish_color_history_current variable #9713, docs
• 6ff971e Fix typo in set docs #9721, docs typo
• 4ed53d4 reader: Apply fish_color_selection fg color and options in vi visual mode #9717, apply foreground color for selection
• bbe2a2b Shortening descriptions for (some) gcc commands #9722, completion descriptions
• 36e4b0f add completion for ar #9720, ar completion
• 8a0510a add qjs completion #9723, qjs completion
• fdd4bcf completions/git: Allow switch to complete remote branches #9718, git switch remote branches
• bda9d57 Ansible completion: fix typo in --limit-hosts #9732, ansible typo
• 9e22357 Fix composer require completion #9734, composer require
• db5c9ba Git completion is broken (but kinda works?) #9738, git with '()' path
• f5e063a add-qjsc-fish #9731, qjsc completions
• 5640390 Create fish_[default|vi]_key_bindings documentation #9728, docs for fish_X_key_bindings
• beca704 add recent commits to completion for git switch --detach #9742/9741, git switch completions
• 30ae715 completions: added ip neigh completions #9743, ip completions
• 480133b completions: improved jq #9740, jq/gojq completions
• 20b500d Add rpm-ostree completion #9669/9667, rpm-ostree
• 93dc848 Remove kitty completion in favor of official integration #9750, remove kitty completions
• b76e6c5 complete: fix condition to suppress variable autocompletion #9753, don't autosuggest with bare $
• d855725 fish dnf package complete broke on Fedora 38: complete: Skipping completions for non-existent command #9783, dnf lowercase
• 5f672ec fish_update_completions creates invalid files if man file is duplicated #9787, don't read man page twice
• 67d1d80 When using curses, look for libterminfo as well. #9794, look for tinfo where you look for curses
• aac3036 Missing completions for systemctl subcommands #9804, more systemctl subcommands
• 2016101 feat: sync the dracula official theme #9807, sync dracula theme
• 4e13b1b # Dracula licensing!
• 2eba684 SyntaxWarning: invalid escape sequence '\&' #9814, fix python syntaxwarning
• ffb6168 implement completion for age and age-keygen #9813, age completions
• 6b1e6dd add completions for git update-index #9759, git update-index
• 272d123 Fix a typo in language.rst #9825, doc typo
• b5fae43 added some german translations #9824, german translations
• 6c6d281 added some german translations #9824
• a0a2475 added some german translations #9824
• 71c320c Redraw pager on new selection when nothing was selected previously #9833 / 9812 - sometimes completion pager skips selecting last entry
• 4c9fa51 Force use of macOS's builtin manpath #9817, don't use homebrew manpath
• cbf9a3b improved print CSS for fish_config #9828, print css
• 38ac21b wrong alias definition when command contains a metacharacter (like "+" or backslash) #8720, escape alias when printing
• bab8fb9 Add i o for unzip #9850, unzip i/o completion
• e3e7ab7 add stash completions to git show and git diff #9871, git show/diff stashes
• ac2810e Fix rclone autocompletion script sourcing issue in fish shell #9878, rclone completions
• bfd97ad Fix rclone autocompletion script sourcing issue in fish shell #9878, adding version parsing
• e31c0eb Fix grammar in completion docs #9880, typo
• 72de1dc Docs: fix code block #9882, sphinx code block
• a6c36a0 Parse errors for -c commands don't cause fish to return error #9888, let -c error out
• 6823f5e Poor globbing performance in nfs-mounted directory with lots of subdirectories. #9891, skip an access()
• 0cfdc90 Add i o for unzip #9850 fixup, fix for FreeBSD
• 6325b36 string repeat has an infinite loop #9899/9900 string repeat overflow
• 2bc6056 Add GNU IMP completions #9904, gnu imp completions
• c56f9e1 Docs: correct small grammatical error in read.rst #9915, doc fix
• 8d3885b Add Blender completions #9905, blender completions
• 6ce2ffb Add Krita completions #9903, krita completions
• 2110b36 more gcc -O completion #9914, gcc -O completions
• 9a9e133 add gcc completion lm lz lrt #9919, gcc -lm completions
• ee75b45 Remove a waccess call when completing executables #9931, claw back some perf loss from 9699
• 21ddfab Simplify and fix __fish_is_zfs_feature_enabled #9939, zfs completions
• f9d21cc Add horcrux completion #9922, horcrux completions
• 408ab86 Add iwctl completions #9932/6884, iwctl completions
• 69ef51f Enable PWD reporting for iTerm2 #9955, turn on PWD reporting in iTerm
• c07136e Enhance fish documentation by pointing out there is also fish_cursor_replace #9956, docs
• fd68aca fix __fish_list_current_token not recognizing ~ as $HOME #9954, ~ for alt-l
• 556bee6 completions/iwctl: Show network details in completion #9960, more on iwctl
• 0f19d71 Replace more escapes with quotes in man parser #9961, more quotes in man parse
• 7160017 docs: correct insert mode key #9970, docs
• 6473a9c Shortened completion descriptions for node and rsync #9965, completion description
• 81cd035 Tab completion for apt-get install produces only a subset of options #9972, fix apt completions being incomplete
• 5b1ff94 Right prompt prints "Permission Denied" errors to fish stderr. #9975, silence git in scales prompt
• e555f1b math --scale does not emit trailing zeros #9983, docs
• b48fa1f Css refresh #9982, docs css
• 482616f Cannot use command time in pipeline #9985, allow foo | command time
• b454b3b Cannot use command time in pipeline #9985, allow foo | command and
• 55c425a fish_key_reader: Humanize key descriptions #9986, fish_key_reader key names
• f6123d2 scp completions: fix path escaping #9943 / 9704, scp path escaping
• 9d0d166 Improve completion for rpm-ostree #9910, rpm-ostree completions
• 33ec25d Add macOS java_home completion #9998, java-home completions
• fff320b completions: make: respect line continuations in recipes #9977 / 9976, make completions line continuations
• 0e81d25 # docs
• 5b44c26 reader: Use existing search string when opening the history pager #10005, use existing search string in pager
• 3bf80b2 add gcc completion for link lib #10007, gcc completions libs
• d6e234c completions: add ibmcloud #10004, ibmcloud completions
• NOT APPLIED YET: #### 7534572 Shortening node.fish completions #9994, node completion descriptions (didn't apply cleanly because of reformatting)
• b03327f __fish_complete_command doesn't correctly handle prefixed usage #10011, complete_command --foo= logic
• 3bcde90 completion(loginctl): complete sessions, users, seats #10023, loginctl completions
• 7c5777a completions/pkill: use locals. #10029, pkill local variables
• 10d91b0 file list output by pressing Tab key, some are bold but some are not #9617, pager colors lacking bold
• e6bef40 completions: add watchexec #10027, watchexec completions
• 269c9c3 add completions for crc and oc #10034, crc/oc completions
• 0cdf801 completions/pacman: fix -Qp completing packages, not files #10039, pacman -Qp completions
• f8e3881 Open fails when xdg-open would launch a terminal program #10045, xdg-open with CLI apps
• ff433b0 Runaway cursor when using escape+undo in vi mode #7910, repaint-mode
• 496d65f Variables for single command doesn't work with exec #9995, variable overrides for exec
• a809672 Fix out of scope opt variable #10020, ls $opt scope
• c4ca1a6 Add a clear-screen bind function to clear the screen #10044, clear-screen bind func
• 86803e4 Reduce stat calls for wildcard #10032, reduce stat for wildcards
• added support for fish_sequence_key_delay_ms to set how long to wait between sequence key presses #10008

As well as these commits without an issue:

• ad54f07 # Important doc fix for set.
• 098b709 # fish_config save with multiple values

[krobelus]

sounds good. I'd add some of the history pager changes if I get around to it

[faho]

Some more possible backports:

• support prepending please instead of sudo/doas #9635
• add new variable for external cursor mode #9565
• completions: fix qdbus Q_NOREPLY method completion #9776
• history delete with an index range (delete first/last X entries) #9736
• docs: Add "Writing your own prompt" doc #9841
• history pager: delete selected history entry with Shift-Delete #9515
• escape job commands #9875
• The builtin returns true with garbage arguments #9942
• make fish default theme ansi-only #9913
• Ctrl+R behavior when no matches: cancelled command #9934

I would also love to have #9984 - unfortunately the fix we went with (passing an iterator that knows to skip underscores) isn't something I think we can make work in C++, so we'd have to go with the awkward solution I originally tried.

[krobelus]

yes and #9476

Yeah the C++ equivalent of Iterator::filter is https://en.cppreference.com/w/cpp/ranges/filter_view which is C++20

[rymrg]

Can you please backport this as well?

• Improve fossil prompt execution time #9528

[faho]

Labeled it now. We'll go through the closed issues/prs again and look for more to backport.

[zanchey]

"in a few months" was a bit optimistic but 3.7.0 is on the way soon