Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] [UI]: in collection UI, there is issue of spacing and margin #93

Open
shreya-gr opened this issue Oct 1, 2023 · 9 comments · May be fixed by #101
Open

[bug] [UI]: in collection UI, there is issue of spacing and margin #93

shreya-gr opened this issue Oct 1, 2023 · 9 comments · May be fixed by #101
Labels
good first issue Good for newcomers hacktoberfest Issue that are part of Hacktoberfest

Comments

@shreya-gr
Copy link
Collaborator

Describe the bug
In API collection UI there is issue of margin and spacing, due to that UI get disturbed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to API collection.
  2. You can save few request shows like in the attached screensort, to get the idea about where is the problem.

Expected behavior
There should not be margin and spacing issue.

Screenshots

Screenshot 2023-10-01 at 2 02 08 PM
@shreya-gr shreya-gr added good first issue Good for newcomers hacktoberfest Issue that are part of Hacktoberfest labels Oct 1, 2023
@yatharth1706
Copy link

Hi @shreya-gr, Would love to work on this issue.

@shishiro26
Copy link

I would like to work on this issue

@0xatulpatil
Copy link

Hey @shreya-gr,

I tried to replicate the issue mentioned above and indeed there's some UI spacing/margin issue with the tree-component.

Could you please elaborate on what you exactly mean by fixing the "margin/spacing" issue here?

To fix the issue, two solutions come to my mind

1. Consisten margin to request-tokens

To add a consistent margin across the tokens ( GET, POST, DELETE) which will eliminate the text overlap issue attached in the image above. The updated UI would look something like this.

image

2. Align request-token text to the right of the div.

To ensure that all the request names line up properly, we could align the request tokens (GET, POST, DELETE) to the right of each div, thus nicely lining up the request names. The updated UI with this change would look something like this.

image

I would like to work on this issue. If you have any suggestions or any alternate solution please let me know.

@ayushsgithub
Copy link

For sure there is issue with the content in UI @shreya-gr
Screenshot 2023-10-03 134545

@shreya-gr
Copy link
Collaborator Author

@0xatulpatil Thanks for your suggestion and ideas.

I've 2 suggestion.

  1. 2nd option looks good to me.
  2. How would it look a like if we save graphql and websocket request along with rest.

@0xatulpatil
Copy link

0xatulpatil commented Oct 3, 2023

@shreya-gr
Not 100% accurate, but this is what it will look like if we go with the 2nd solution

image

The only problem being, that we'll have to leave a bit of spacing (this spacing will be the largest request token we have, and this to me looks like the DELETE token) to the left for all the icons.

@Nishchit14
Copy link
Contributor

@0xatulpatil looks good, you can share the PR. currently we can consider the DELETE as the longest prefix.

@0xatulpatil
Copy link

hey @Nishchit14, made PR for the same.

Turns out the OPTIONS token is the longest prefix amongst all. Went with OPTIONS and not DELETE.

@Nishchit14
Copy link
Contributor

that's great @0xatulpatil i am commenting on the PR now. #101

one thought, i think it's fine to go with DELETE length because the real use of OPTIONS is very rare. the most used methods are get/post/put/delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Issue that are part of Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants