Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling get_* multiple times causes dups #2

Open
boguscoder opened this issue Feb 20, 2018 · 1 comment
Open

Calling get_* multiple times causes dups #2

boguscoder opened this issue Feb 20, 2018 · 1 comment

Comments

@boguscoder
Copy link

Parser’s getters are not guarded against multiple calls and not only repeat unnecessary parsing over and over but also populate data vectors with duplicate entries.
At least it would be nice to clean vectos before parsing
At best it may makes sense to cache results
@finixbit
Copy link
Owner

Great idea but its advisable for user calling getters to store them to prevent elf_parser.cpp from holding large parsed data within the program

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@finixbit @boguscoder