Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Currently Streaming Text Is Not Always in View #110

Closed
fingerthief opened this issue May 17, 2024 · 0 comments · Fixed by #116
Closed

[Bug] Currently Streaming Text Is Not Always in View #110

fingerthief opened this issue May 17, 2024 · 0 comments · Fixed by #116
Assignees
@fingerthief
Labels
bug Something isn't working
Milestone
6.1.2

Comments

@fingerthief
Copy link
Owner

Describe the bug

Occasionally the text that is streaming is not being auto scrolled into view during the stream process.

After the stream process finishes it also does not scoll the finished message into view fully.

To Reproduce

Steps to reproduce the behavior:

  1. Most easily reproduced in mobile layout
  2. Enter prompts that output a decent amount of text (a short story, or list of things)
  3. Observe the stream and see if it is auto scrolling to the bottom properly.

Expected behavior

Ideal behavior should be the most recent portion of the streamed response text should always be in view while the streaming process is active.
@fingerthief fingerthief added the bug Something isn't working label May 17, 2024
@fingerthief fingerthief added this to the v6.1.1 milestone May 17, 2024
@fingerthief fingerthief mentioned this issue May 17, 2024
Merged
@fingerthief fingerthief modified the milestones: v6.1.1, 6.1.2 May 17, 2024
fingerthief added a commit that referenced this issue May 18, 2024
@fingerthief
Updated the message-items component to use the unique message id prop…
41d97ce 
…erties for the key value.

Removed the showing/hiding of the streaming message text element.

Updated so that the actual message object is being updated when a response is being streamed.

This [Bug] Occasionally the Streaming Text Is Not Visible At All for the First Few Messages #100

This fixes the issue [Bug] Currently Streaming Text Is Not Always in View #110

This also fixes the screen/text flashing after a message stream has finished. Instead saves are not noticable to the user aside from the context window length value updating
@fingerthief fingerthief mentioned this issue May 18, 2024
Merged
@fingerthief fingerthief self-assigned this May 18, 2024
@fingerthief fingerthief linked a pull request May 18, 2024 that will close this issue
Restructured Message Text Streaming UI Updating Process #116
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fingerthief fingerthief

Labels
bug Something isn't working
Projects
MinimalChat
Status: Done
Milestone
6.1.2
Development

Successfully merging a pull request may close this issue.

Restructured Message Text Streaming UI Updating Process fingerthief/minimal-chat
1 participant
@fingerthief