Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host examples on vercel? #1

Open
Valve opened this issue Feb 17, 2022 · 3 comments
Open

Host examples on vercel? #1

Valve opened this issue Feb 17, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Valve
Copy link
Member

Valve commented Feb 17, 2022

Would it be possible to host the examples on Vercel?

@borislobanov92
Copy link
Contributor

It would be possible but I'm not sure I see a lot of value in it. The examples are mainly useful for 2 reasons in my opinion: a) users will be able to look at the code to see how to integrate the hook and b) they will be able to serve them locally and tweak something to see how the changes affect results.
Hosting the demo would mainly showcase the use of the JS agent (however nothing about it is React specific) and the caching mechanism that will be only noticeable with the Network and Application tabs open in DevTools. Still I'm not sure that hosting examples will increase adoption of the React SDK.
But I'm keeping an open mind :)

@Valve
Copy link
Member Author

Valve commented Feb 17, 2022

Thanks, let's keep this open to invite more community votes.

@EmmanuelTheCoder
Copy link

I agree with @borislobanov92. Perhaps, we could put it on CodeSandbox so that users can make changes and see how it affect results.

@JuroUhlar JuroUhlar added the enhancement New feature or request label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants