Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpringEntityLeakDetector crashes with Map #706

Open
nchandrashekar79 opened this issue Jun 20, 2023 · 1 comment
Open

SpringEntityLeakDetector crashes with Map #706

nchandrashekar79 opened this issue Jun 20, 2023 · 1 comment
Labels

Comments

@nchandrashekar79
Copy link

nchandrashekar79 commented Jun 20, 2023

Environment

Component Version
Java 1.8
SpotBugs 4.5.3.0+
FindSecBugs 1.12

Problem

Problem

SpringEntityLeakDetector does not seem to support the case when an argument is a Map:
     java.lang.IllegalArgumentException: Invalid class name 
	 java/lang/String;Ljava/util/List<Lcom/test/entity/HelloBean
       At edu.umd.cs.findbugs.classfile.ClassDescriptor.<init>(ClassDescriptor.java:59)
       At edu.umd.cs.findbugs.classfile.DescriptorFactory.getClassDescriptor(DescriptorFactory.java:128)
       At edu.umd.cs.findbugs.AnalysisCacheToRepositoryAdapter.loadClass(AnalysisCacheToRepositoryAdapter.java:90)
       At org.apache.bcel.Repository.lookupClass(Repository.java:65)
       At com.h3xstream.findsecbugs.spring.SignatureParserWithGeneric.typeToJavaClass(SignatureParserWithGeneric.java:75)
       At com.h3xstream.findsecbugs.spring.SignatureParserWithGeneric.getReturnClasses(SignatureParserWithGeneric.java:60)
       At com.h3xstream.findsecbugs.spring.SpringEntityLeakDetector.analyzeMethod(SpringEntityLeakDetector.java:112)
       At com.h3xstream.findsecbugs.spring.SpringEntityLeakDetector.visitClassContext(SpringEntityLeakDetector.java:69)

Code

@Controller
public class SpringEntityLeakController  {

	@RequestMapping("/api1")
	public HashMap<String, ?> getHelloBeans() {

		HashMap<String, List<HelloBean>> map = new HashMap<>();

		List<HelloBean> list = new ArrayList<>();

		list.add(new HelloBean("1", "name1"));
		list.add(new HelloBean("2", "name2"));
		map.put("data", list);
		return map;
	}

}

class HelloBean {
	String id;
	String name;
	public HelloBean(String id, String name) {
		super();
		this.id = id;
		this.name = name;
	}

}
@perwramdemark
Copy link

+1

@h3xstream h3xstream added the bug label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants