CTRL+ALT stop working after opening and closing a tab

[alexjp]

Description

First of all, thanks for this project, very well done, Congratulations!

The mode I most like to use is when enabling firefoxpwa.enableHidingIconBar and manually showing it and hiding it, according to my wishes.

Unfortunately, it has a bug, which is that if I close a tab, the hotkeys stop working.

Steps to Reproduce

1. open a firefox PWA site
2. open a second tab (tabs enabled)
3. close tab
4. ctrl + alt dont work no more

Additional Information

Did not see any special info in devtools or firefoxpwa logs when DEBUG file created

Affected Websites

Does not seem specific to particular websites

Environment

• Operating system: Linux
• System architecture: x86-64
• Desktop environment: KDE
• Installation method: Arch chaotic package and browser extension
• PWAsForFirefox extension version: 2.8.0
• PWAsForFirefox native version: 2.8.0
• PWAsForFirefox runtime version:
• Firefox version: 119.0

[filips123]

What happens when you try using Ctrl+Alt then? Does it simplly not switch tabs, even if more are opened?

I tried to reproduce this on Windows, bur it works fine for me. I will later probably also try to reproduce it on KDE.

[alexjp]

What happens when you try using Ctrl+Alt then? Does it simplly not switch tabs, even if more are opened?

just does not "show or hide" (toggles) the icon bar (like if the keys are not pressed)

[filips123]

After a bit more testing, I was able to reproduce it. I don't know what exactly I did, and it doesn't happen every time...

Actually, I now tested it a bit more, and it seems the icon bar stays visible after a URL popup (F6) is shown. And even if I hide it again from the customize page, it cannot be toggled with a shortcut anymore.

I'm still not sure why this happens though.

[alexjp]

After a bit more testing, I was able to reproduce it. I don't know what exactly I did, and it doesn't happen every time...

Actually, I now tested it a bit more, and it seems the icon bar stays visible after a URL popup (F6) is shown. And even if I hide it again from the customize page, it cannot be toggled with a shortcut anymore.

Glad that you were able to reproduce. In here it happens everytime I close a second/next tab.
Sorry, I didn't remembered to test with the URL popup :(

I'm still not sure why this happens though.

Well, its not a showstopper bug :)

[filips123]

Did you open/close a second tab with keyboard shortcuts or through UI? I think I found a bug with the shortcut for F6 (the set of pressed keys isn't cleared after pressing F6), but I don't know what caused problems when oepning/closing tabs.

[alexjp]

Did you open/close a second tab with keyboard shortcuts or through UI? I think I found a bug with the shortcut for F6 (the set of pressed keys isn't cleared after pressing F6), but I don't know what caused problems when oepning/closing tabs.

That is probably it! I just tested several times opening and closing tabs through the mouse only, and all good! ... as soon as I opened and closed with CTRL+W, it stopped working!

Using CTRL+W is almost second nature to me (using keyboard shortcuts as well), so didn't even remembered testing it! :(

[filips123]

It's still weird as CTRL+W works fine for me on Windows. Maybe it's something specific to Linux or KDE, I'll try to test this there in the future.

To fix this, I'll probably have to rework a bit how shortcut detection for CTRL+ALT works, and I'm not sure yet how exactly to do it and how long it will take.

[alexjp]

It's still weird as CTRL+W works fine for me on Windows. Maybe it's something specific to Linux or KDE, I'll try to test this there in the future.

To fix this, I'll probably have to rework a bit how shortcut detection for CTRL+ALT works, and I'm not sure yet how exactly to do it and how long it will take.

:) thanks ! For me at least, don't worry about the time :) I am used to had the tab strip hidden with some tabs. So, it would be a plus, to be able to show/hide when needed, but not critical! (again, at least for me)

Thank you for your awesome work!