Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading indicator is still displayed when opening out-of-scope URLs in a different browser #381

Open
joulev opened this issue Aug 6, 2023 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@joulev
Copy link

joulev commented Aug 6, 2023

Description

See title. I'm not sure if this is a bug or not, but it's definitely unintended behaviour to me.

Steps to Reproduce

  1. Install any apps. For example install example.com
  2. Enable "Open out-of-scope URLs in a default browser"
  3. Click on an out-of-scope URL. In example.com there is the "More information" link that goes to an out-of-scope URL.
  4. The link is opened in my default browser as expected; but the app window icon is changed to the loading icon (and since the page is never opened in the app browser, the loading icon is always there until I force-reload the page by using ctrl+r or similar). I don't think this should happen.

What should happen

I think at least the out-of-scope links shouldn't trigger the loading icon. I would even prefer that the loading icon is never triggered by any links, out-of-scope or not, though this is purely personal preference.

Additional Information

See the title bar here

Screenshot 2023-08-06 at 1 40 05 PM

Affected Websites

I reckon this will happen anywhere. But I've tested and found this bug on

  • discord.com which is where I mainly use the extension ← whenever I click any links, the loading indicator will stay there until I force-reload or close the app
  • example.com which is the reproduction I wrote above

Environment

  • Operating system: macOS Sonoma public beta
  • System architecture: Apple M2
  • Installation method: Homebrew + Firefox extension store
  • PWAsForFirefox extension version: 2.7.3
  • PWAsForFirefox native version: 2.7.3
  • PWAsForFirefox runtime version: 2.7.3
  • Firefox version: 116.0.1
@joulev joulev added the bug Something isn't working label Aug 6, 2023
@filips123
Copy link
Owner

Yeah, it's a bug. I'll try to fix it.

You can also hide the loading icon so it never appears. If you want to do this, add the following CSS to your userChrome.css:

@-moz-document url('chrome://browser/content/browser.xhtml') {
  .tab-throbber {
    visibility: hidden;
  }
}

You can find instructions for creating userChrome.css on the website. Follow the steps that are mentioned there, but copy this CSS instead of those from the website.

@filips123 filips123 added this to the 3.0.0 milestone Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To Do
Development

No branches or pull requests

2 participants