Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display detailed upload progress in notification #155

Open
shawnmaten opened this issue Jan 26, 2018 · 6 comments
Open

Display detailed upload progress in notification #155

shawnmaten opened this issue Jan 26, 2018 · 6 comments
Assignees

Comments

@shawnmaten
Copy link
Contributor

shawnmaten commented Jan 26, 2018

It was intended from the start to have detailed upload progress notifications for individual files.

  • bytes sent / bytes total
  • moving average bitrate
  • moving average ETA

There are 2 major blockers to enabling this.

The first thing that needs to be solved is this issue in the Java SDK. filestack/filestack-java#51 The base SDK was supposed to provide the necessary progress updates for this, as a stream of progress objects from the upload observable, but that isn't working. And looking at the code now, I did not understand how parallelism was working in RX. So that all needs to be sorted out but I think the idea of the RX interface is fine, it's just not straightforward to have RX be parallel. (I still might be really lacking in RX understanding here.)

The other thing is that the UploadService needs some work. The IntentService won't work with non-blocking code. If we subscribe to an observable for the upload, we won't be blocking, and the service would just quit. So instead of an IntentService we need a base Service or maybe something else. And more recent versions of Android have introduced tougher restrictions to prevent battery draining (there's now a job scheduling system, JobIntentService, other things I've skimmed in press releases) so we should conform to that.

@mtariquekhan
Copy link

Hi shawnmaten,
Is there any update related to progress percent while uploading file. We need this to include in our project to show progress to the user while uploading.

@shawnmaten
Copy link
Contributor Author

Added to internal tracker: https://filestack.atlassian.net/browse/FS-3356

@shawnmaten
Copy link
Contributor Author

@mtariquekhan I don't have an update on this right now but it's still planned to be fixed.

@mhswtf
Copy link

mhswtf commented Oct 19, 2018

Is there any new progress on this issue?

@mtariquekhan
Copy link

is there any progress @shawnmaten?

@shawnmaten
Copy link
Contributor Author

Hey just a heads up @mhswtf and @mtariquekhan I no longer work at Filestack so I wouldn't know about any internal progress on this. You might try mentioning the most recent committer or sending an inquiry through Support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants