Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions about python code style #37

Open
lurenpluto opened this issue Aug 23, 2023 · 2 comments
Open

Some suggestions about python code style #37

lurenpluto opened this issue Aug 23, 2023 · 2 comments

Comments

@lurenpluto
Copy link
Contributor

After looked at the mvp branch of some of the latest commit code, feel inside the python code writing style maybe some conflict, in accordance with the management, our python code style should follow the PEP-8 specification, as follows

https://peps.python.org/pep-0008/

where

Class names should normally use the CapWords convention.

So the code below corresponds to

The correct class name for agent_manager should be AgentManager. @waterflier

@waterflier
Copy link
Collaborator

Inherited from my C/Rust habits, I've gotten used to all-lowercase. Thank you for your suggestion; I've read the relevant guidelines, and I'll adjust my code later to meet PEP-8 requirements.

P.S
I've been using the pylint tool, but it doesn't seem to have flagged this issue.

@waterflier
Copy link
Collaborator

Refactoring is complete.
5454009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants