Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Sass layer #422

Open
ffoodd opened this issue Jun 30, 2021 · 4 comments
Open

Improve Sass layer #422

ffoodd opened this issue Jun 30, 2021 · 4 comments
Labels
enhancement help welcome
Projects
CSS modernisation

Comments

@ffoodd
Copy link
Owner

ffoodd commented Jun 30, 2021 •
edited

A few conventions could help newcomers a bit:

  • $_ for private variables,
  • !default flag for public variables, to ease customization,
  • use Dart Sass new module system,
  • etc.
@ffoodd ffoodd mentioned this issue Nov 26, 2021
Closed
@ffoodd ffoodd added this to To do in CSS modernisation Jun 2, 2022
@kawaljen
Copy link

Hey, I am new to open source contributing, Can I work on this issue?

@ffoodd
Copy link
Owner Author

ffoodd commented Jun 21, 2023

You may give it a try if you're comfortable enough with Sass best practices—however I don't have a clear goal on the topic, so not quite sure of what can be done.

@kawaljen
Copy link

kawaljen commented Jul 7, 2023

Ok I'll leave it, cause the sass code seems pretty well as it is.. but maybe I have missed something

@ffoodd
Copy link
Owner Author

ffoodd commented Jul 7, 2023

Thanks for your interest though!

@ffoodd ffoodd mentioned this issue Aug 21, 2023
Open
Repository owner deleted a comment Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help welcome
Projects
CSS modernisation
Status: To do
CSS modernisation
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ffoodd @kawaljen