Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout#activate returns false #165

Open
etherbob opened this issue Aug 15, 2022 · 3 comments
Open

Rollout#activate returns false #165

etherbob opened this issue Aug 15, 2022 · 3 comments

Comments

@etherbob
Copy link

In the past when using $rollout.activate from the console there'd be a string response "OK"

After updating to rollout 2.5.0 my team-mates and I noticed that the activate method is returning false though it appears to be succeeding in activating the feature.

Wondering if this is intended behavior or some leakage from the save or notify_observers methods?

@reneklacan
Copy link
Member

@etherbob Good catch. Yes, it's intended behaviour change.

@etherbob
Copy link
Author

@etherbob Good catch. Yes, it's intended behaviour change.

@reneklacan would you say a little more about the reasoning behind the change? I was trying to find a ticket or changelog entry so I could understand it and share with some colleagues.

@etherbob
Copy link
Author

@reneklacan specifically the confusion for us is that having #activate return false at the console level seems to indicate failure. If that's intentional it'd be great to have some docs that say what false is meant to imply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants