Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] macOS 14 displays focusRing #329

Open
peterpaulis opened this issue Oct 4, 2023 · 2 comments · May be fixed by #330
Open

[BUG] macOS 14 displays focusRing #329

peterpaulis opened this issue Oct 4, 2023 · 2 comments · May be fixed by #330
Labels
bug Something isn't working

Comments

@peterpaulis
Copy link

Describe the bug
on macOS a focus ring is shown as soon the user starts to interact with the pages

To Reproduce

  • run on macOS 14
  • start to swipe

Expected behavior
no focus ring should be shonw, or there should be the option to disable focusable and those keyboard control

Screenshots / Videos

Screen.Recording.2023-10-04.at.15.55.19.mov

Environment:

  • OSX: macOS 14, XCode 15
  • SwiftUIPager version: 2.5.0

Additional context
Add any other context about the problem here.
@peterpaulis peterpaulis added the bug Something isn't working label Oct 4, 2023
peterpaulis added a commit to peterpaulis/SwiftUIPager that referenced this issue Oct 4, 2023
@peterpaulis
Update Pager+Buildable.swift
ea8f0dc 
Fixing fermoya#329
peterpaulis added a commit to peterpaulis/SwiftUIPager that referenced this issue Oct 4, 2023
@peterpaulis
Update Pager.swift
bc33345 
fixing fermoya#329
peterpaulis added a commit to peterpaulis/SwiftUIPager that referenced this issue Oct 4, 2023
@peterpaulis
Update PagerContent+Buildable.swift
2f48c53 
fixing fermoya#329
peterpaulis added a commit to peterpaulis/SwiftUIPager that referenced this issue Oct 4, 2023
@peterpaulis
Update PagerContent.swift
0a3e9b7 
Fixing fermoya#329
@peterpaulis peterpaulis linked a pull request Oct 4, 2023 that will close this issue
Open
@peterpaulis
Copy link
Author

peterpaulis commented Oct 4, 2023 •
edited

if my pull request gets accepted,

.allowsKeyboardControl(false)

can be used to disable keyboard control and the focus ring

@mayqiyue
Copy link

mayqiyue commented Apr 1, 2024

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@peterpaulis @mayqiyue