-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser undo/redo behavior seems to be broken #110
Comments
I looked into it further and I believe I have narrowed it down to the focus event listener being added here: vue-form/src/directives/vue-form-validator.js Lines 89 to 91 in 48a08bb
I have seen consistently that I remove that event listener, undo/redo behavior is solid, but when I replace it, the issues crop again. I am not yet clear why, but figured I'd share in case this sheds any light. Edit: Changing the native event listener to 'focusin' as opposed to 'focus' seems to resolve the issue and still seems to work. However, I would hesitate to suggest this without a better understanding of the cause. |
I have been digging into this quite a bit trying to find the root cause, but have had no luck so far. For a while, I still thought it might have been something about my implementation specifically, but then I noticed I could recreate the issue on one of the example jsfiddles: https://jsfiddle.net/fergal_doyle/bqys2p5y/
The behavior I am describing is in Chrome. There also seems to be issues in Firefox, but they are a bit different because Firefox doesn't support undo/redo the same Chrome does.
To recreate:
I'm very open to assisting with a fix for this, but I am struggling to identify the cause. The only thing I can think of is that perhaps the frequent watch triggers start to run out of order, but I am throwing darts at this point.
The text was updated successfully, but these errors were encountered: