Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TypeScript is not a dependency #2

Open
prattcmp opened this issue Oct 16, 2023 · 0 comments · May be fixed by #3
Open

[BUG] TypeScript is not a dependency #2

prattcmp opened this issue Oct 16, 2023 · 0 comments · May be fixed by #3

Comments

@prattcmp
Copy link

prattcmp commented Oct 16, 2023

TypeScript is used in package.json for postinstall, but its not listed a dependency in package.json. Projects that don't have TypeScript installed by default (in our case we only have vue-tsc) will fail to install.

We resolved this by adding "typescript": "^5.2.2", to our own dependencies, but the proper fix would be for this project to add the typescript npm package to dependencies (not devDependencies; postinstall only relies on dependencies) or to remove the tsc command from postinstall.

@prattcmp prattcmp linked a pull request Oct 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant