-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2139 add maxpy and mdot support #2141
Conversation
prudhomm
commented
Jul 14, 2023
•
edited
edited
- Have you checked to ensure there aren't other open Pull Requests for the same change?
- Have you added an explanation of what your changes do and why you'd like us to include them?
- Have you written new tests for your changes?
- Have you successfully run the Feel++ testsuite with your changes locally?
- Have you written Doxygen comments in your contribution ?
- closes implement nirb framework for elliptic problems #1912
- closes Reduce NIRB complexity #1950
- closes use nirb approx in greedy algorithm #2038
- closes test nirb convergence #2041
- closes Fix NIRB execution #2125
- closes add maxpy and mdot support to Vector class #2139
…into 1912-implement-nirb-tools [ci skip]
the architecture is present but still bugs in it [ci skip]
[ci skip]
/cc @alielarif [skip feelpp, skip tests, skip toolboxes, skip mor]
#1912 [ci skip]
[ci skip]
now scripts Offline.py and Online.py are installed and can be loaded. The function implemented are used in test_nirb for now only offline has been refactored [ci skip]
…2041-test-nirb-convergence
[ci skip]
[ci skip]
[ci skip]
…implement nirb tools in feel++ #1912
…or test nirb convergence #2041
…2041-test-nirb-convergence
[ci skip]
@prudhomm It also seems that the wrapping has been broken : https://buildkite.com/feelpp/feelpp/builds/4980#01895eda-c34a-41c0-b040-e791c442f410/695-1122 |
…ture /cc @thomas-saigre skip feelpp skip tests skip toolboxes skip mor #2139
[ci skip]
add header to stl for conversion test not passing yet /cc @prudhomm [ci skip]
convert by hand the feelpp._core.WorldsComm in a List[feelpp._core.WroldComm] [skip feelpp, skip toolboxes, skip mor, skip tests] /cc @prudhomm
because the wrapping of add(List[float], List[vector]) messed it up /cc @prudhomm [skip feelpp, skip tests, skip mor, skip toolboxes]
@@ -175,10 +175,11 @@ def functionSpace( mesh, space="Pch", order=1, worldscomm=None): | |||
""" | |||
if worldscomm is None: | |||
worldscomm = Environment.worldsComm(1) | |||
worldscomm_list = [worldcomm for worldcomm in worldscomm] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -276,7 +276,7 @@ PYBIND11_MODULE(_alg, m ) | |||
.def( "addVector", static_cast<void ( Vector<double>::* ) | |||
( std::shared_ptr<Vector<double>> const& , std::shared_ptr<MatrixSparse<double>> const& ) | |||
>( &Vector<double>::addVector ), "add the product of a MatrixSparse and a vector to this vector" ) | |||
.def( "add", [](Vector<double> &v, double a, Vector<double> const& w){ v.add(a, w); }, "add a scalar*vector to this vector" ) | |||
.def( "addVector", [](Vector<double> &v, double a, Vector<double> const& w){ v.add(a, w); }, "add a scalar*vector to this vector" ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prudhomm With the wrapping add(List[float] alphas, List[vector] vs)
computing add(float alpha, vector v)
computing
A workaround I found is to rename this method to addVector
so it can be wrapped correctly. Maybe there is another way to do it...
[ci skip]
- fix offline execution and refactor code with removing some loops - fix onlien execution : used the right number of basis functions #2139 [skip feelpp, skip toolboxes, skip mor, skip tests]
[skip feelpp, skip mor, skip tests, skip toolboxes]
@thomas-saigre I sync'ed with develop. there is still work to do in mor |
[ci skip]
…eelpp into 2139-add-maxpy-and-mdot-support [ci skip]
[skip feelpp, skip tests]
Stale pull request message |
Stale pull request message |
…eelpp into 2139-add-maxpy-and-mdot-support
Stale pull request message |