Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert error on panic #17

Open
erkie opened this issue Feb 14, 2019 · 0 comments
Open

Alert error on panic #17

erkie opened this issue Feb 14, 2019 · 0 comments
Labels
help wanted Would love help from other contributors

Comments

@erkie
Copy link
Member

erkie commented Feb 14, 2019

Right now the backup fails silently if a panic happens somewhere. This should at minimum be alerted about so manual cleanup steps can be taken.

Or also run appropriate cleanup steps when applicable. It feels like a good time to refactor out the return backupCleanup logic to be a if err := recover(); err != nil { backupCleanup() } and that backupCleanup is smart enough to know when it is safe to delete the volume or not.

@erkie erkie added the help wanted Would love help from other contributors label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Would love help from other contributors
Projects
None yet
Development

No branches or pull requests

1 participant