-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(typebox): Typebox package should export the Value APIs #2927
Comments
This is strangely turning out to be more complicated than I thought. For some reason just declaring the Since the dependency gets installed automatically anyway, I recommend loading it from |
Another workaround would be to load from ./node_modules/ directly. You can go as far as to use subpath exports to make it easier to do this in several files. @daffl If a package inside node_modules that doesn't support ESM loads a package, any package, it will always pick the CommonJS version, even if the user-land package.json is set to type=module. You could have also ran into an issue with conditional exports and how you have to the more specific conditions like "node", "deno" and "development" above vague ones like "default" or "browser". I'm happy to help get these issues expedited... I was hoping to have a CJS problem free year... i've been dealing with this since 2019 as you know. |
Steps to reproduce
The
@feathersjs/typebox
package doesn't export the super useful values module.Happy to submit a PR for this.
Expected behavior
Actual behavior
"Cannot find module"
System configuration
Tell us about the applicable parts of your setup.
Module versions (especially the part that's not working):
NodeJS version: 16.13.2
Operating System: macOS
Browser Version:
React Native Version:
Module Loader:
The text was updated successfully, but these errors were encountered: