Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to create a WebApplication without the defaults #37

Open
davidfowl opened this issue Mar 1, 2021 · 3 comments
Open

Add way to create a WebApplication without the defaults #37

davidfowl opened this issue Mar 1, 2021 · 3 comments

Comments

@davidfowl
Copy link
Collaborator

davidfowl commented Mar 1, 2021

Maybe we need 2 overloads:

  • WebApplication.CreateBuilder - Less stuff? console logger and no configuration providers.
  • WebApplication.CreateDefaultBuilder - What we have today

OR do we do nothing and require users to clear logging and configuration providers.

@thenameless314159
Copy link

No configuration provider for the CreateBuilder overload ? This won't take any string[] args then ?

I don't think my opinion is required but both would be good, maybe expose an extension method to clear both providers and make an overload that call it after creating the builder instead of an almost empty builder ?

@davidfowl
Copy link
Collaborator Author

I'm worried about the choices. Too many choices would confuse people so what the defaults are and what are in them need to be intuitive.

@thenameless314159
Copy link

thenameless314159 commented Mar 2, 2021

I see, since feather aim to provide more straightforward webhost building logic you can't expect people to knows what the aspnetcore WebHost.CreateDefaultBuilder() does (since the default feather webhost make rather similar registrations if I'm not mistaken) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants