Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iss 260 add maxabs nan documentation #289

Closed
wants to merge 2 commits into from
Closed

Iss 260 add maxabs nan documentation #289

wants to merge 2 commits into from

Conversation

jcrawford
Copy link

Add documentation for nan argument to the maxabs function. Fixes #260

@santisoler
Copy link
Member

Hi @jcrawford. Thanks for opening this PR!
Just a minor comments:

  1. I would revert the changes from the first commit, which are the same present in Fix typos on docstrings #288. We encourage to split changes that solve different issues on different PRs.
  2. The CIs are failing because the modification on the docstring is not in agreement with the numpydoc style and PEP8. You can run make format to autoformat the code and then check if anything else need some work by running make check and make lint. You can read more about how we manage code style on our Contributing Guidelines.

@santisoler
Copy link
Member

The author hasn't addressed the requested changes after 14 days, so we decided to close this PR for now.

@santisoler santisoler closed this Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing description of nan argument in maxabs
2 participants
@jcrawford @santisoler