Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the terminal color output API #159

Open
zindel opened this issue May 16, 2019 · 2 comments
Open

Unify the terminal color output API #159

zindel opened this issue May 16, 2019 · 2 comments

Comments

@zindel
Copy link
Member

zindel commented May 16, 2019

Fastpack was started a while ago before Pastel was introduced. Because of this we came up with a limited implementation of the colored output. See FastpackUtil/Terminal.re, specifically print_with_color function.

It would be great to get rid of this function in favour of the Pastel. An example of the Pastel usage in the Fastpack codebase can be seen in Fastpack/Commands.re.

The related issue is the clearScreen function which is known to work on MacOS/Linux terminals, but I totally don't know if it works on Windows. So, it'd be useful to test and fix it to be truly cross-platform.

zindel added a commit that referenced this issue May 29, 2019
@Ishaan28malik
Copy link

Is it still pending ?
@zindel

@zindel
Copy link
Member Author

zindel commented Aug 13, 2019

@Ishaan28malik, @davesnx has completed the first part. The second part clearScreen is still pending. I.e. if it works on Windows we can safely close it, if it doesn't - the fix would be much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants