New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(lorem): define allowed words #2885
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2885 +/- ##
========================================
Coverage 99.95% 99.96%
========================================
Files 2977 2977
Lines 215466 215469 +3
Branches 597 951 +354
========================================
+ Hits 215372 215384 +12
+ Misses 94 85 -9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about using normal words if they dont use Latin. 🤔
Oh wow, then I completly misunderstood what we discussed in the team meeting when we made the decision. Discuss again in tomorrows meeting? |
We should survey what current non-Latin locales actually do and document that (eg are they nonsense words or real words or transliterations of Latin lorem?) |
25 locales currently have a lorem/words.ts file. For each i generated 5 sample words Latin
Non-latin(im not really enough of an expert in non-Latin languages to tell if these are nonsense or real words)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested rewrite. In some ways the concept of "lorem ipsum" is unique to Latin-based languages, because you can write words using Ancient Latin, a dead language, that are "foreign" and yet immediately obvious as "words" in most Latin-based languages.
So I'm not sure there's a definite "best" way to handle lorem-ipsum in non-Latin languages. In some languages it may make sense to transliterate Latin words into the script like "l-o-r-e-m", in other cases you may just want to us random words or characters.
@@ -2,6 +2,9 @@ import type { LocaleEntry } from './definitions'; | |||
|
|||
/** | |||
* The possible definitions related to lorem texts. | |||
* | |||
* The words in this module are determined by the ISO 15924 script of the locale. | |||
* If a locale uses the Latin script, it will utilize Latin lorem words, while a locale using the Cyrillic script will use Cyrillic lorem words, and so forth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* If a locale uses the Latin script, it will utilize Latin lorem words, while a locale using the Cyrillic script will use Cyrillic lorem words, and so forth. | |
* If a locale uses the Latin script, it should generally utilize Latin "lorem ipsum" words, while a locale using another script should use real or nonsense words to give the same effect as Latin lorem text. |
Team Proposal
|
Would it make more sense to move the lorem definitions to the base locale? |
I was not available at last team meeting, and I'm missing any reasons 👀 |
Because all locales that use Latin characters, use Latin anyway. And those that dont, use normal words and are sometimes even incompatible with the Latin sentence structure. |
Description
Document the expected words for a locale in the lorem module.
Related to
This is the first part of #2884.