-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SponsKrub removes thumbnail embedded in MKV video #29
Comments
To summarize the issue: A workaround to this issue from my side would be to embed thumbnail AFTER sponskrub has done its job. But it is probably best if a solution can be implemented in sponskrub itself |
Workaround for faissaloo/SponSkrub#29 Closes #204
I can confirm that this issue is now resolved with f4e4be1 :) |
the issue isnt "resolved". I worked around it by doing this
imo, this issue should still be kept open since it affects users who use sponskrub separately from yt-dlp too |
I'm so sorry for the confusion... |
So I've spent some time going through a bunch of the ffmpeg documentation and stuff, it looks like there's not really a standard way to deal with existing thumbnails, however adding a thumbnail as thing independent of the original seems fairly straightforward as does extracting an image from a video. Would generating a new thumbnail for the video (which might be different) be an acceptable solution? It might also make more sense given the fact that what's in the thumbnail might end up getting cut out |
Maybe as a workaround or alternative, but being able to maintain the thumbnail should be preferred as the fix since the original may be artwork from outside the video. |
Workaround for faissaloo/SponSkrub#29 Closes yt-dlp#204
@pukkandan advised me to open an issue here concerning removed thumbnail embedded in MKV video.
Long story short, see yt-dlp/yt-dlp#204.
Is there a way to solve this issue?
The text was updated successfully, but these errors were encountered: