New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch "Safari" and "Safari Mobile" in a single check #685
Labels
Comments
maphe
changed the title
Catch "Safari" and "Safari" mobile in a single check
Catch "Safari" and "Safari Mobile" in a single check
Oct 18, 2023
Hi! Thanks for the suggestion, as a general rule, I'll consider to add a feature if there are enough users who need it as well. In the mean time we can also use browser.name.includes("Safari") |
Cool thanks, that's what I ended up doing but it is case-sensitive, which Thanks for considering, and thank for the work. |
Somewhat related question: Is Safari detected as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Today
is("Safari")
is does not catch variants likeMobile Safari
. That's one example I came across but now I'm wondering if I'm missing other cases.Describe the solution you'd like
It would be nice to have a helper function similar to
is()
but doing string matching instead of equality (eg.match()
). I imagine that'd also help forWindows
andWindows Phone
and some other cases.Describe alternatives you've considered
Right now I'm doing
is("Safari") || is("Mobile Safari")
but that feels a little precarious.Thanks
The text was updated successfully, but these errors were encountered: