Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close left panel issue #43

Open
dfaizmaulana opened this issue Oct 9, 2018 · 3 comments
Open

Close left panel issue #43

dfaizmaulana opened this issue Oct 9, 2018 · 3 comments

Comments

@dfaizmaulana
Copy link

Hi thanks for this nice library, its really helpful for n00b like me.

I try to close left panel from left panel view controller by using panel?.closeLeft()
What i expect is left panel will be closed with animation slide out, but what i get is only left panel closed without any slide out animation.
Is there any configuration that i do incorrectly?
screen shot 2018-10-09 at 17 18 32

@fahidattique55
Copy link
Owner

@dfaizmaulana

You need to call openCentre function. Let me know if it works otherwise I will share some code example with you.

Thanks & regards

@dfaizmaulana
Copy link
Author

@fahidattique55

I tried to call panel?.openCenter(animated: true) as well, but still no animation happen.
I'm just wondering if panel?.closeLeft() should be call from center panel rather than on left panel, because when i try to call panel?.openLeft(animated: true) from center panel the animation is work.

@fahidattique55
Copy link
Owner

@dfaizmaulana

I got the issue you are facing. There are two ways to hide the left panel.

  1. Change the center panel animated
  2. slideLeftPanelOut in the FAPanel+Animation.swift file

The second way is a function but internal for now. So I will push a new update to give the option you want. Otherwise if you will tap on centre panel the left panel will get close with animation. Or if you will change the center panel, the left panel will also get close with animation.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants