Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual testing #252

Open
Josh-Cena opened this issue May 1, 2022 · 0 comments
Open

Visual testing #252

Josh-Cena opened this issue May 1, 2022 · 0 comments

Comments

@Josh-Cena
Copy link
Contributor

Josh-Cena commented May 1, 2022

With a lot of CSS refactors / polishings under the way, we should find a way to ensure they don't regress. Testing CSS on Infima is much easier than Docusaurus, and also much more vital.

I have taken some inspiration from TypeDoc's visual regression CI. From my discussion with Gerrit, it's supposed to be fairly easy, without app installation / service subscription. The only problem when it's not connected to some external service is there's no way to easily retrieve the testing artifacts.

I wonder if we can:
(a) Connect to an AWS S3/equivalent so we can store the snapshots
(b) Use a GH comment action to post the artifact
(c) Install the reg-suit app which seems promising

We can do our tests exclusively on the /demo page, which should make things a lot easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant