Skip to content
This repository has been archived by the owner on May 30, 2019. It is now read-only.

23rd of next month does not get recognized #235

Open
sagarjs opened this issue Mar 28, 2017 · 1 comment
Open

23rd of next month does not get recognized #235

sagarjs opened this issue Mar 28, 2017 · 1 comment

Comments

@sagarjs
Copy link

sagarjs commented Mar 28, 2017

Hi,

Would be great if you could also handle a phrase like:
"23 of next month"

Currently it understands it as the first of the next month

@almostimplemented
Copy link
Contributor

May just need some fiddling with the rules. Search <day-of-moth> in resources/languages/en/rules/time.clj. For what it's worth, "the 23rd of next month" works out-of-the-box:

duckling.core=>  (load! {:config {:en$time {:corpus ["numbers" "time"] :rules ["cycles" "duration" "numbers" "time"]}}})
{:en$time (:number :time :ordinal :cycle :unit-of-duration :duration :timezone)}
duckling.core=> (play :en$time "the 23rd of next month" [:time] (default-context :now))
W ----------------------  12 | time      | intersect by "of", "from", "'s" | P = -8.4524 | the <day-of-month> (
      --                  11 | null      | number (as relative minutes) | P = -1.0987 | integer (numeric)
      --                  10 | time      | time-of-day (latent)      | P = -0.7685 | integer (numeric)
  ------                   9 | time      | the <day-of-month> (non ordinal) | P = -0.1360 |  + integer (numeric)
      ----                 8 | time      | <day-of-month> (ordinal)  | P = -0.7397 | ordinal (digits)
  --------                 7 | time      | the <day-of-month> (ordinal) | P = -0.0465 |  + ordinal (digits)
      --                   6 | time      | year (latent)             | P = -1.1775 | integer (numeric)
              ----------   5 | time      | next <cycle>              | P = -1.5404 |  + month (cycle)
      ----                 4 | ordinal   | ordinal (digits)          | P = -0.0465 | 
      --                   3 | number    | integer (numeric)         | P = -0.1360 | 
                   -----   2 | unit-of-duration | month (unit-of-duration)  | P = 0.0000 | 
                   -----   1 | cycle     | month (cycle)             | P = 0.0000 | 
  the 23rd of next month

1 winners:
time                      {:type "value", :value "2017-04-23T00:00:00.000-07:00", :grain :day, :values ({:type "value", :value "2017-04-23T00:00:00.000-07:00", :grain :day})} {:label :time, :direction nil}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants