-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify 2-d matrix types #260
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are currently multiple types representing 2 dimensional matrices:
Vec<Vec<E>>
,RowMatrix
,ColMatrix
, and maybe others. I suggest we only have 2:RowMajorMatrix
andColumnMajorMatrix
.data
buffer, similar to what today'sRowMatrix
hasVec<Vec<E>>
. For example,EvaluationFragment::update_row()
would simply delegate to the internalColumnMajorMatrix
as opposed to (re-)implementing that logic there.The main benefits of this approach are:
Vec<Vec<E>>
stores columns or rowsVec<Vec<E>>
(such as thisEvaluationFragment::update_row()
,ColMatrix
,RowMatrix
) would all live in one placeVec<Vec<E>>
(cache locality)The text was updated successfully, but these errors were encountered: