-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic in merkle's verify_batch #200
Comments
Thank you for catching this! This shouldn't be too difficult to fix. Basically, we should detect an invalid depth (probably during deserialization) and just return an error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As is currently implemented, if a malicious prover lies about the depth of their Merkle tree, it will cause the verifier to panic.
The panic can be reproduced by replacing this line in the test (
winterfell/crypto/src/merkle/tests.rs
Line 219 in 0acb2a1
with
is this an inherent limitation or can this be worked around?
The text was updated successfully, but these errors were encountered: