{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":58146669,"defaultBranch":"main","name":"sapling","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-05-05T16:53:47.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1718137296.0","currentOid":""},"activityList":{"items":[{"before":"c0d3638b0ea489c017d2e6f4d261a3e0d6db29e2","after":"62780e868b831d42fec8f85917e0991550b94d68","ref":"refs/heads/main","pushedAt":"2024-06-12T23:14:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"debugGetScmTree -> debugGetTree\n\nSummary: Implemented a new API debugGetTree to replace the original debugGetScmTree which has limited options available. The new api supports fetching the cache info of a tree from multiple layers, just like the other two edenfs debug commands: `blob` and `blobmeta`.\n\nReviewed By: kmancini\n\nDifferential Revision: D58057223\n\nfbshipit-source-id: cdf158ad24fd83cc0c6f4100d40322c541bc948e","shortMessageHtmlLink":"debugGetScmTree -> debugGetTree"}},{"before":"d8f0e9b470d80eee238e3bbf1899e83968a7a455","after":"c0d3638b0ea489c017d2e6f4d261a3e0d6db29e2","ref":"refs/heads/main","pushedAt":"2024-06-12T21:48:37.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"convert AugmentedTreeEntry into EdenApi tree with Files Metadata and Directory Metadata\n\nSummary: convert augmented tree into EdenApi tree\n\nReviewed By: muirdm\n\nDifferential Revision: D58418948\n\nfbshipit-source-id: 3a7ebdb42d81f4c496f1dc838d202b8f4e632a07","shortMessageHtmlLink":"convert AugmentedTreeEntry into EdenApi tree with Files Metadata and …"}},{"before":"b6c7f224f61417d6d44767e0e0168b1a2e608c9b","after":"d8f0e9b470d80eee238e3bbf1899e83968a7a455","ref":"refs/heads/main","pushedAt":"2024-06-12T17:25:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"commit cloud: return workspace info on edenapi service\n\nSummary: This the way the http service does it, so let's be compatible with that\n\nReviewed By: markbt\n\nDifferential Revision: D58424996\n\nfbshipit-source-id: bcc3a68048d0106bf71c58bb886b817758334500","shortMessageHtmlLink":"commit cloud: return workspace info on edenapi service"}},{"before":"8bfd94befbc45293430b846b0b8628b7a446de5a","after":"b6c7f224f61417d6d44767e0e0168b1a2e608c9b","ref":"refs/heads/main","pushedAt":"2024-06-12T16:37:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/390d5d94cfc856e7b72e842b0e0b330598a7b328\nhttps://github.com/facebook/fb303/commit/1b410a6099592b6accb1d2bdc5c0c183e4e1f85a\nhttps://github.com/facebook/fbthrift/commit/b07562ce9a683acd032c0e51d246ec89276d2f39\nhttps://github.com/facebook/folly/commit/c640d6cd31b9ce6077a1aa6ebde7304d8ecc6fe9\nhttps://github.com/facebook/mvfst/commit/39cfb960185b666f9e20383c319d6cdcdcb828ca\nhttps://github.com/facebook/proxygen/commit/a36073679c938aade198e92d108d4e7519dbcb38\nhttps://github.com/facebook/wangle/commit/2207d0a0764070472ac9e01eff6503edf6db659d\nhttps://github.com/facebookexperimental/edencommon/commit/f0aed68fbcce052f380d61c3acd6f81d800d1dbd\nhttps://github.com/facebookexperimental/rust-shed/commit/c096de640c100cbeadf903dad8c7ce5adbff23b2\nhttps://github.com/facebookincubator/fizz/commit/ee600b8dcdfb3b21a62be5257261448b9fd3aedd\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: 159dc38c954716477edf8a0c0592e1d58dae8298","shortMessageHtmlLink":"Updating submodules"}},{"before":"b027c13c146ad6cacc337fad52b56697895008d9","after":"8bfd94befbc45293430b846b0b8628b7a446de5a","ref":"refs/heads/main","pushedAt":"2024-06-12T15:54:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"bookmarks_movement: Stop doing unbounded work on bookmark creation\n\nSummary:\nFixes a bottleneck in Live Git Sync and gitimport for chromium/src.\n\nBefore this change, the same restrictions enforcement would run again and again on public commits.\nWith this change, we restrict the set of commits on which to check restrictions to the subset of draft commits being pushed.\n\nOne example where this helps is this:\nWe have a long branch that diverged from master a long time ago. We are creating a tag on that branch.\nWithout this change, we would do `O(n_commits_in_long_branch)` checks per tag creation, including re-checking the same commits we already checked over and over again.\nFor gitimport, this becomes `O(n^2)`.\nAfter this change, we would do 0 checks in that scenario, or `O(n_new_commits_being_pushed)` in a slightly different scenario, which is the exact set we are interested in running checks for.\n\nUse a jk for the rollout because this code is on the hot path for lands for fbsource, so we will want to rollout the jk while monitoring push throughput to make sure we don't unintentionally cause a SEV if the delay added for finding the precise boundary is significant in this context.\n\nReviewed By: gustavoavena\n\nDifferential Revision: D58245003\n\nfbshipit-source-id: 4ed8d2d542eaa92527d8667222bfee504d629586","shortMessageHtmlLink":"bookmarks_movement: Stop doing unbounded work on bookmark creation"}},{"before":"d24a542cb8ac791411d7c18b0b8c7b1e39166774","after":"b027c13c146ad6cacc337fad52b56697895008d9","ref":"refs/heads/main","pushedAt":"2024-06-12T14:22:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Replace dummy commit graph storage with memwrites implementation\n\nSummary:\nIn the child diff, we change the data derivation mechanics to leverage the power of the commit graph.\n\nWithout this change, `cross_repo_sync` doesn't support data derivation accessing the `CommitGraph` as it hits any of the `unimplemented!` points in the code removed in this diff.\n\nReviewed By: gustavoavena\n\nDifferential Revision: D58239336\n\nfbshipit-source-id: cdb662dd4cf632539369c2fe520e4b775e5f6cbb","shortMessageHtmlLink":"Replace dummy commit graph storage with memwrites implementation"}},{"before":"dc19419f0f03db3b1b3b3745120882d272bca288","after":"d24a542cb8ac791411d7c18b0b8c7b1e39166774","ref":"refs/heads/main","pushedAt":"2024-06-12T13:07:37.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"easy: commit cloud: Move versions out of sql\n\nSummary: Cause I want to add more specific functions that aggregate sql handling (see next diff)\n\nReviewed By: markbt\n\nDifferential Revision: D58428271\n\nfbshipit-source-id: 3e8dc6f597a5dee29052fcce9e0064de4bd85fb4","shortMessageHtmlLink":"easy: commit cloud: Move versions out of sql"}},{"before":"6795e3e8e3860f83fb729497ef2e8bbf9ec2c7dd","after":"dc19419f0f03db3b1b3b3745120882d272bca288","ref":"refs/heads/main","pushedAt":"2024-06-12T10:13:17.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make the repo stats logger optional\n\nSummary:\nWe'll default false to be safe and enable it as we go, starting with one region as a canary.\n\n Checking in a loop is not ideal, but it allows us to enable/disable without a restart. Once the rollout and testing is complete we'll want to make this unconditional anyway.\n\nDifferential Revision: D58407389\n\nfbshipit-source-id: 38176ebf197d337499088f0f14e090fefc3e66db","shortMessageHtmlLink":"Make the repo stats logger optional"}},{"before":"7c96c1b4666bab989801f6d95bf86d0dcdc465d2","after":"6795e3e8e3860f83fb729497ef2e8bbf9ec2c7dd","ref":"refs/heads/main","pushedAt":"2024-06-12T09:57:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"eden/mononoke/tests/integration\n\nReviewed By: andreacampi\n\nDifferential Revision: D58455977\n\nfbshipit-source-id: 9c2109bcac7397b7c9e2803e6181267d0e5a9105","shortMessageHtmlLink":"eden/mononoke/tests/integration"}},{"before":"db60885e827e551d41fe479b2543b627dd719ede","after":"7c96c1b4666bab989801f6d95bf86d0dcdc465d2","ref":"refs/heads/main","pushedAt":"2024-06-12T08:43:07.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"phases: Fix the list-public command in test environments\n\nSummary:\nThe parent diff showed a bug in test environments.\nThis test is caused by a query that works correctly in prod with mysql, but not in tests with sqlite.\n\nProvide a correct spelling of the query for tests.\n\nReviewed By: markbt\n\nDifferential Revision: D58417227\n\nfbshipit-source-id: b130ab32f127e8c9ac0ef93a32c3fd1d62a3e1d1","shortMessageHtmlLink":"phases: Fix the list-public command in test environments"}},{"before":"1d1185cc46f1a8392b83200c7106b32be7888d2b","after":"db60885e827e551d41fe479b2543b627dd719ede","ref":"refs/heads/main","pushedAt":"2024-06-12T02:40:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update libsodium download URL\n\nSummary:\nOld libsodium downloads moved to a different URL breaking the build, e.g. https://github.com/facebook/fbthrift/actions/runs/9464211012/job/26071044729:\n\n```\nDownload with https://download.libsodium.org/libsodium/releases/old/libsodium-1.0.17-msvc.zip -> Z:\\downloads\\libsodium-libsodium-1.0.17-msvc.zip ...\nTransientFailure: Failed to download https://download.libsodium.org/libsodium/releases/old/libsodium-1.0.17-msvc.zip to Z:\\downloads\\libsodium-libsodium-1.0.17-msvc.zip: HTTP Error 404: Not Found\n```\n\nFix it.\n\nReviewed By: bigfootjon\n\nDifferential Revision: D58435760\n\nfbshipit-source-id: cfbb7efba646c5255c9eb62722b0190c272cc340","shortMessageHtmlLink":"Update libsodium download URL"}},{"before":"b59e54b26b2147c871628447888ec89d0735c671","after":"1d1185cc46f1a8392b83200c7106b32be7888d2b","ref":"refs/heads/main","pushedAt":"2024-06-12T01:02:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"set up Augmented Trees types\n\nSummary: set up Augmented Trees types\n\nReviewed By: muirdm\n\nDifferential Revision: D58381051\n\nfbshipit-source-id: dd41c9be7620500cf1761722b6aa6db3e61cb46a","shortMessageHtmlLink":"set up Augmented Trees types"}},{"before":"c6f50909580d72532d2f49fe6afc3ecd68d36bea","after":"b59e54b26b2147c871628447888ec89d0735c671","ref":"refs/heads/main","pushedAt":"2024-06-12T00:26:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"cleanup zombie processes\n\nSummary:\nUpdate EdenFS's SIGCHLD handler to handle unintentional zombie processes like\n`sl debugrefreshconfig`.\n\nReviewed By: MichaelCuevas\n\nDifferential Revision: D58424191\n\nfbshipit-source-id: e1213281915f29dbf13d316bf30ef84fc274a0fc","shortMessageHtmlLink":"cleanup zombie processes"}},{"before":"eae1e54a1beace03955cc66af8553366d725f51b","after":"c6f50909580d72532d2f49fe6afc3ecd68d36bea","ref":"refs/heads/main","pushedAt":"2024-06-12T00:19:22.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"pydag: make nameset's `+` operation preserve order\n\nSummary:\nMake it possible to preserve set order like in Python. This can be potentially\nbreak things (either behavior-wise or performance-wise). A config is added to\nrestore the old behavior in case it breaks things.\n\nThe `|` operation is kept unchanged - it does not preserve order.\n\n| layer | `+` | `|` | note |\n| revsetlang | preserve order | preserve order | public API, cannot change |\n| Python smartset | preserve order [1] | not defined [4] | private API, widely used |\n| Binding nameset | not preserve order [2] -> preserve order | not preserve order | `repo.dageval`, private API, less widely used |\n| Rust NameSet | not defined -> preserve order [3] | not preserve order | private API, very limited use |\n\n[1]: Except for the `nameset` or `idset` backed by bindings `pydag` [2].\n[2]: This was an implementation limitation, not intentional. See D22519584 for related subtle test changes.\n[3]: added recently in D58308085.\n[4]: plan to define it given \"unordered union\" seems a frequent operation.\n\nSo the near term final state is that `+` always preserves order in all layers. `|` does not preserve in all layers except for the revsetlang.\nIdeally revsetlang can be updated about the `|`. However that might be potentially breaking and we need to be very careful rolling it out.\n\nReviewed By: zzl0\n\nDifferential Revision: D58312755\n\nfbshipit-source-id: 3d485cfbcdada543b87d7174e4f6e823713c1819","shortMessageHtmlLink":"pydag: make nameset's + operation preserve order"}},{"before":"4b6ba1f7cdff2e35e92aa054fcbf3a835c4c2922","after":"97f8dcdcbde590221b79a03dea9aad420ce699be","ref":"refs/heads/gh-pages","pushedAt":"2024-06-12T00:05:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: eae1e54a1beace03955cc66af8553366d725f51b","shortMessageHtmlLink":"deploy: eae1e54"}},{"before":"1da854b0f6eae571359be9269a8a8bab27a99ffd","after":"eae1e54a1beace03955cc66af8553366d725f51b","ref":"refs/heads/main","pushedAt":"2024-06-11T22:06:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Regenerate cratemaps to contain Thrift filepaths\n\nSummary:\nGenerated by `arc autocargo` from the fbcode_macros changes made by {D58398534}.\n\nI pulled these out to a different diff to leave the handwritten changes in D58398534 more easily reviewable, but they will need to be landed together.\n\nReviewed By: zertosh\n\nDifferential Revision: D58398840\n\nfbshipit-source-id: 7f50978c4bce31def9e041d67f28ba4d29745635","shortMessageHtmlLink":"Regenerate cratemaps to contain Thrift filepaths"}},{"before":"e9b2eaa926d8a9181791f17b06c0feff4e11f28a","after":"1da854b0f6eae571359be9269a8a8bab27a99ffd","ref":"refs/heads/main","pushedAt":"2024-06-11T21:34:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"pre-commit warning for large sloc commits\n\nSummary: this diff adds the Split suggestion banner to the commit mode w/ some minor mods to the verbiage to encourage folks to select less files.\n\nReviewed By: evangrayk\n\nDifferential Revision: D58418870\n\nfbshipit-source-id: 458dc9be3f06c7e58799c8acab47c91aa19508f2","shortMessageHtmlLink":"pre-commit warning for large sloc commits"}},{"before":null,"after":"fecfa2fbb608726ed378395d878e22835f7c508c","ref":"refs/heads/dependabot/npm_and_yarn/eden/contrib/braces-3.0.3","pushedAt":"2024-06-11T20:21:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"build(deps): bump braces from 3.0.2 to 3.0.3 in /eden/contrib\n\nBumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.\n- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)\n- [Commits](https://github.com/micromatch/braces/compare/3.0.2...3.0.3)\n\n---\nupdated-dependencies:\n- dependency-name: braces\n dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"build(deps): bump braces from 3.0.2 to 3.0.3 in /eden/contrib"}},{"before":"55e089a83da88b43752b4fadaefa0c74e57e60d9","after":"e9b2eaa926d8a9181791f17b06c0feff4e11f28a","ref":"refs/heads/main","pushedAt":"2024-06-11T20:19:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"third-party/rust: Update riscv crate\n\nReviewed By: AlexanderSidorenkoFB\n\nDifferential Revision: D58366028\n\nfbshipit-source-id: f384b942b8c7c6389045873fff36f734391724b3","shortMessageHtmlLink":"third-party/rust: Update riscv crate"}},{"before":"0415abae8576f78f405d473bee2e1bc5f133ed50","after":"55e089a83da88b43752b4fadaefa0c74e57e60d9","ref":"refs/heads/main","pushedAt":"2024-06-11T17:59:20.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"tests: fix types on tests/watchman.py\n\nSummary: Seems like these were never triggered since Pyre doesn't run on the `tests/` directory\n\nReviewed By: quark-zju\n\nDifferential Revision: D58389166\n\nfbshipit-source-id: 9e9f22a860f6afada361c6ad4197438325e5f04d","shortMessageHtmlLink":"tests: fix types on tests/watchman.py"}},{"before":"66e5ef21b66648723295a8682329ed4389b8a940","after":"0415abae8576f78f405d473bee2e1bc5f133ed50","ref":"refs/heads/main","pushedAt":"2024-06-11T16:39:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/0b921907258e0b67e3911020b5c51fcab65b4d9d\nhttps://github.com/facebook/fb303/commit/9e60ac48ae5dbe4a43e3aef382181a5df95dc52a\nhttps://github.com/facebook/fbthrift/commit/0ca43f98fd892f7151e3046b94b56099f0470ba6\nhttps://github.com/facebook/folly/commit/5329008dd75679e7c50b8c271af75bdc80eb8bdd\nhttps://github.com/facebook/mvfst/commit/7864be592e2b094323241b376cf7d9065dc14562\nhttps://github.com/facebook/proxygen/commit/f4cde99baa6e27104f5c4d02805e0d195875dcb1\nhttps://github.com/facebook/wangle/commit/e1387989810ff74e016bfa4d404ed3682ba782a0\nhttps://github.com/facebookexperimental/edencommon/commit/85b46f0986e5005b51338ff4eaf7a580c6ab6471\nhttps://github.com/facebookexperimental/rust-shed/commit/d15a194e01214b542ed13259bf708427a5fb2872\nhttps://github.com/facebookincubator/fizz/commit/38d136ab3b6a4909dca6ecaa64d301a17cb40f57\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: 91ee93ad20bbe1607af048fe791af6818e728147","shortMessageHtmlLink":"Updating submodules"}},{"before":"32b78980d40d90f4b51e7ad3d983da66421cdd74","after":"66e5ef21b66648723295a8682329ed4389b8a940","ref":"refs/heads/main","pushedAt":"2024-06-11T16:11:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Enable git client to drive negotiation in Git protocol\n\nSummary:\nWith the server side implementation of Mononoke commit graph, within just a single request we can figure out exactly the set of commits that needs to be sent to the client. However, Git being Git, the client doesn't advertise all the HAVEs in one go and likes to play a couple rounds of negotiation before arriving at the smallest set of commits to be sent across.\n\nSo far the server would look at the first set of HAVEs sent by the client and immediately start sending the packfile. As a result, we would sent an accurate yet unnecessarily big packfile. This diff ensures that we engage in as many rounds of negotiations as needed by the client and only start sending the packfile when the client sends the done flag.\n\nNOTE: This problem is peculiar since it doesn't occur in every repo. The repo needs to be big enough, have large number of commits and a healthy commit rate for this issue to show up (e.g. oculus/aosp/vendor/oculus or chromium/src)\n\nReviewed By: gustavoavena\n\nDifferential Revision: D58291027\n\nfbshipit-source-id: 81d41becb6f42cb9c2ed2f8ad15db34e2a7d7141","shortMessageHtmlLink":"Enable git client to drive negotiation in Git protocol"}},{"before":"cd94d3bdcc0cc8fa54bb23a1ceb0b0cb7938caa0","after":"32b78980d40d90f4b51e7ad3d983da66421cdd74","ref":"refs/heads/main","pushedAt":"2024-06-11T15:54:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"contrib: fix a couple issues in dot-t-mode.el\n\nSummary:\n- expected output mods like \"(glob)\" don't have a trailing space\n- run-tests.py --with-hg needs an absolute path\n\nReviewed By: quark-zju\n\nDifferential Revision: D58412554\n\nfbshipit-source-id: f9ceabec6b4a33fc127900ffcd4cee4690d73ab3","shortMessageHtmlLink":"contrib: fix a couple issues in dot-t-mode.el"}},{"before":"befaa25494ef03309d25134de853c91941923ff2","after":"cd94d3bdcc0cc8fa54bb23a1ceb0b0cb7938caa0","ref":"refs/heads/main","pushedAt":"2024-06-11T14:01:10.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"checkout: fix error output for edenapi errors\n\nSummary: Track store fetch errors separately from \"other\" errors and output a max of 5 errors under a \"error fetching files\" section.\n\nReviewed By: quark-zju\n\nDifferential Revision: D58216862\n\nfbshipit-source-id: 63ff82c91361a4baa08aa0d52a916cae5186fc7c","shortMessageHtmlLink":"checkout: fix error output for edenapi errors"}},{"before":"663f2f27b75439cccfe7d6ff0ea0d2cbaee2f433","after":"befaa25494ef03309d25134de853c91941923ff2","ref":"refs/heads/main","pushedAt":"2024-06-11T03:46:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Regenerate thrift_build.rs with chained builder methods\n\nSummary: Generated changes resulting from {D58395388}.\n\nReviewed By: zertosh\n\nDifferential Revision: D58395387\n\nfbshipit-source-id: 2c2df0c09a79dd8cb5cd740016d485a94588693c","shortMessageHtmlLink":"Regenerate thrift_build.rs with chained builder methods"}},{"before":"1b9233e435220a98f5ad9bdfbe544e1c746f192e","after":"663f2f27b75439cccfe7d6ff0ea0d2cbaee2f433","ref":"refs/heads/main","pushedAt":"2024-06-11T02:36:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Regenerate thrift_build.rs without base path canonicalization\n\nSummary: Generated changes resulting from {D58388072}.\n\nReviewed By: zertosh\n\nDifferential Revision: D58388074\n\nfbshipit-source-id: a0f8804f25bf35c4effb566c867aefc32396e4f6","shortMessageHtmlLink":"Regenerate thrift_build.rs without base path canonicalization"}},{"before":"9758373efb5e4d99a713a8c293ab1fe412400aa8","after":"1b9233e435220a98f5ad9bdfbe544e1c746f192e","ref":"refs/heads/main","pushedAt":"2024-06-11T01:33:00.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add integration test for eden glob\n\nSummary: This is an integration test for EdenAPI offloaded eden glob command\n\nReviewed By: sggutier\n\nDifferential Revision: D57869198\n\nfbshipit-source-id: 7547de96ab6ad5f253dcf1995d747042dbc5f9ad","shortMessageHtmlLink":"Add integration test for eden glob"}},{"before":"cdd67caada67a272b07a33c308bd0350e3ec4c9f","after":"4b6ba1f7cdff2e35e92aa054fcbf3a835c4c2922","ref":"refs/heads/gh-pages","pushedAt":"2024-06-11T00:05:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 9758373efb5e4d99a713a8c293ab1fe412400aa8","shortMessageHtmlLink":"deploy: 9758373"}},{"before":"b6d8d2b1af25f7b4d762120b9fc944b9ce2a5581","after":"9758373efb5e4d99a713a8c293ab1fe412400aa8","ref":"refs/heads/main","pushedAt":"2024-06-10T23:42:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"github: refactor create_pull_request_title_and_body() (#902)\n\nSummary:\n[sl] github: refactor create_pull_request_title_and_body()\n\nThis diff makes create_pull_request_title_and_body() have one parameter that\nhas to be either `commit_msg: str` or `(title, body): Tuple[str, str]`.\n\nPull Request resolved: https://github.com/facebook/sapling/pull/902\n\nTest Plan:\n```\n./run-tests.py test-ext-github-ghrevset.t test-ext-github-pr-submit-closed.t test-ext-github-pr-submit-overlap.t test-ext-github-pr-submit-placeholder-issue.t test-ext-github-pr-submit-single.t\n...\n----------------------------------------------------------------------\n# Ran 5 tests, 0 skipped, 0 failed.\n```\n\nReviewed By: sggutier\n\nDifferential Revision: D58318462\n\nPulled By: zzl0\n\nfbshipit-source-id: c72dc76caedcc566a5af78186d963daa8ed15c8b","shortMessageHtmlLink":"github: refactor create_pull_request_title_and_body() (#902)"}},{"before":"5fff99d4febe67f216da58dcfc8b1579c86ea301","after":"b6d8d2b1af25f7b4d762120b9fc944b9ce2a5581","ref":"refs/heads/main","pushedAt":"2024-06-10T22:47:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"contrib: add emacs mode for dot-t tests\n\nSummary: Syntax highlighting, compilation regex, test running, and entrypoint into \"debugrestoretest\" (requires vterm).\n\nReviewed By: sggutier\n\nDifferential Revision: D58313946\n\nfbshipit-source-id: 79f30f6816e003f31cfa2c1fd52bda8b141bb6ac","shortMessageHtmlLink":"contrib: add emacs mode for dot-t tests"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEY9O2egA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/sapling"}