{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":10270250,"defaultBranch":"main","name":"react","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-05-24T16:15:54.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715346306.0","currentOid":""},"activityList":{"items":[{"before":"2c022b847ed2171c59d37db9f71b394e0082ae3f","after":"9d76c954cfe134d7f541c3e706e344e6845ba235","ref":"refs/heads/main","pushedAt":"2024-05-10T13:37:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sebmarkbage","name":"Sebastian Markbåge","path":"/sebmarkbage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/63648?s=80&v=4"},"commit":{"message":"[Flight] Error if a legacy React Element is attempted to be rendered (#29043)\n\nThis errors on the client normally but in the case the `type` is a\r\nfunction - i.e. a Server Component - it wouldn't be transferred to error\r\non the client so you end up with a worse error message. So this just\r\nimplements the same check as ChildFiber.","shortMessageHtmlLink":"[Flight] Error if a legacy React Element is attempted to be rendered (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2289654030\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29043\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29043/hovercard\" href=\"https://github.com/facebook/react/pull/29043\">#…</a>"}},{"before":"c43831f438d012badca318ba803e204ec77779de","after":null,"ref":"refs/heads/use-native-processing","pushedAt":"2024-05-10T13:05:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"NickGerleman","name":"Nick Gerleman","path":"/NickGerleman","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/835219?s=80&v=4"}},{"before":null,"after":"c43831f438d012badca318ba803e204ec77779de","ref":"refs/heads/use-native-processing","pushedAt":"2024-05-10T13:04:20.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"NickGerleman","name":"Nick Gerleman","path":"/NickGerleman","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/835219?s=80&v=4"},"commit":{"message":"fix-typo","shortMessageHtmlLink":"fix-typo"}},{"before":"0952db3456c2483888d17083197c670fbcebde5c","after":"8290a1fa3d08c96e2633ff7a122844a42426c26f","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-05-10T10:04:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Clean up the enableEarlyReturnForPropDiffing experiment (#29041)\n\n## Summary\n\nThe experiment has shown no significant performance changes. This PR\nremoves it.\n\n## How did you test this change?\n```\nyarn flow native\nyarn lint\n```\n\nDiffTrain build for commit https://github.com/facebook/react/commit/2c022b847ed2171c59d37db9f71b394e0082ae3f.","shortMessageHtmlLink":"Clean up the enableEarlyReturnForPropDiffing experiment (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2289396273\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29041\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29041/hovercard\" href=\"https://github.com/facebook/react/pull/29041\">#29041</a>)"}},{"before":"6ef0dd4f2cf6a6083bfadb6a445d348cc7815849","after":"2c022b847ed2171c59d37db9f71b394e0082ae3f","ref":"refs/heads/main","pushedAt":"2024-05-10T10:00:04.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"dmytrorykun","name":"Dmytro Rykun","path":"/dmytrorykun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14206200?s=80&v=4"},"commit":{"message":"Clean up the enableEarlyReturnForPropDiffing experiment (#29041)\n\n## Summary\r\n\r\nThe experiment has shown no significant performance changes. This PR\r\nremoves it.\r\n\r\n## How did you test this change?\r\n```\r\nyarn flow native\r\nyarn lint\r\n```","shortMessageHtmlLink":"Clean up the enableEarlyReturnForPropDiffing experiment (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2289396273\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29041\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29041/hovercard\" href=\"https://github.com/facebook/react/pull/29041\">#29041</a>)"}},{"before":"6c409acefde29d6ef87dfb208716ec3272bd3c54","after":"6ef0dd4f2cf6a6083bfadb6a445d348cc7815849","ref":"refs/heads/main","pushedAt":"2024-05-10T00:56:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sebmarkbage","name":"Sebastian Markbåge","path":"/sebmarkbage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/63648?s=80&v=4"},"commit":{"message":"[Flight] Enable Binary and ReadableStreams in Stable (#29035)\n\nThese are ready to ship in stable.","shortMessageHtmlLink":"[Flight] Enable Binary and ReadableStreams in Stable (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2288027873\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29035\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29035/hovercard\" href=\"https://github.com/facebook/react/pull/29035\">#29035</a>)"}},{"before":"38d9f156b898c9b0f7e73eeec7c2073927fd71d8","after":"6c409acefde29d6ef87dfb208716ec3272bd3c54","ref":"refs/heads/main","pushedAt":"2024-05-10T00:00:56.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sebmarkbage","name":"Sebastian Markbåge","path":"/sebmarkbage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/63648?s=80&v=4"},"commit":{"message":"[Flight Reply] Encode Objects Returned to the Client by Reference (#29010)\n\nStacked on #28997.\r\n\r\nWe can use the technique of referencing an object by its row + property\r\nname path for temporary references - like we do for deduping. That way\r\nwe don't need to generate an ID for temporary references. Instead, they\r\ncan just be an opaque marker in the slot and it has the implicit ID of\r\nthe row + path.\r\n\r\nThen we can stash all objects, even the ones that are actually available\r\nto read on the server, as temporary references. Without adding anything\r\nto the payload since the IDs are implicit. If the same object is\r\nreturned to the client, it can be referenced by reference instead of\r\nserializing it back to the client. This also helps preserve object\r\nidentity.\r\n\r\nWe assume that the objects are immutable when they pass the boundary.\r\n\r\nI'm not sure if this is worth it but with this mechanism, if you return\r\nthe `FormData` payload from a `useActionState` it doesn't have to be\r\nserialized on the way back to the client. This is a common pattern for\r\nhaving access to the last submission as \"default value\" to the form\r\nfields. However you can still control it by replacing it with another\r\nobject if you want. In MPA mode, the temporary references are not\r\nconfigured and so it needs to be serialized in that case. That's\r\nrequired anyway for hydration purposes.\r\n\r\nI'm not sure if people will actually use this in practice though or if\r\nFormData will always be destructured into some other object like with a\r\nlibrary that turns it into typed data, and back. If so, the object\r\nidentity is lost.","shortMessageHtmlLink":"[Flight Reply] Encode Objects Returned to the Client by Reference (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2282090130\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29010\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29010/hovercard\" href=\"https://github.com/facebook/react/pull/29010\">#2…</a>"}},{"before":"7a78d030281f2f0e02e7cdbed5c1fc5c4a1a1823","after":"38d9f156b898c9b0f7e73eeec7c2073927fd71d8","ref":"refs/heads/main","pushedAt":"2024-05-09T23:24:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sebmarkbage","name":"Sebastian Markbåge","path":"/sebmarkbage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/63648?s=80&v=4"},"commit":{"message":"[Flight Reply] Dedupe Objects and Support Cyclic References (#28997)\n\nUses the same technique as in #28996 to encode references to already\r\nemitted objects. This now means that Reply can support cyclic objects\r\ntoo for parity.","shortMessageHtmlLink":"[Flight Reply] Dedupe Objects and Support Cyclic References (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2279901444\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/28997\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/28997/hovercard\" href=\"https://github.com/facebook/react/pull/28997\">#28997</a>)"}},{"before":"732aef73b0e50862673a0a8a5a1cc0e22e0a04c0","after":"0eecce38627b64ab6a4e9313720a74e4a26e8ab0","ref":"refs/heads/builds/facebook-www","pushedAt":"2024-05-09T23:21:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"[Flight] Encode references to existing objects by property path (#28996)\n\nInstead of forcing an object to be outlined to be able to refer to it\nlater we can refer to it by the property path inside another parent\nobject.\n\nE.g. this encodes such a reference as `'$123:props:children:foo:bar'`.\n\nThat way we don't have to preemptively outline object and we can dedupe\nafter the first time we've found it.\n\nThere's no cost on the client if it's not used because we're not storing\nany additional information preemptively.\n\nThis works mainly because we only have simple JSON objects from the root\nreference. Complex objects like Map, FormData etc. are stored as their\nentries array in the look up and not the complex object. Other complex\nobjects like TypedArrays or imports don't have deeply nested objects in\nthem that can be referenced.\n\nThis solves the problem that we only dedupe after the third instance.\nThis dedupes at the second instance. It also solves the problem where\nall nested objects inside deduped instances also are outlined.\n\nThe property paths can get pretty large. This is why a test on payload\nsize increased. We could potentially outline the reference itself at the\nfirst dupe. That way we get a shorter ID to refer to in the third\ninstance.\n\nDiffTrain build for [7a78d030281f2f0e02e7cdbed5c1fc5c4a1a1823](https://github.com/facebook/react/commit/7a78d030281f2f0e02e7cdbed5c1fc5c4a1a1823)","shortMessageHtmlLink":"[Flight] Encode references to existing objects by property path (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2279856062\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/28996\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/28996/hovercard\" href=\"https://github.com/facebook/react/pull/28996\">#28996</a>)"}},{"before":"c3345638cbb4a53df8151fd9ef106ea018fb5033","after":"7a78d030281f2f0e02e7cdbed5c1fc5c4a1a1823","ref":"refs/heads/main","pushedAt":"2024-05-09T23:16:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sebmarkbage","name":"Sebastian Markbåge","path":"/sebmarkbage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/63648?s=80&v=4"},"commit":{"message":"[Flight] Encode references to existing objects by property path (#28996)\n\nInstead of forcing an object to be outlined to be able to refer to it\r\nlater we can refer to it by the property path inside another parent\r\nobject.\r\n\r\nE.g. this encodes such a reference as `'$123:props:children:foo:bar'`.\r\n\r\nThat way we don't have to preemptively outline object and we can dedupe\r\nafter the first time we've found it.\r\n\r\nThere's no cost on the client if it's not used because we're not storing\r\nany additional information preemptively.\r\n\r\nThis works mainly because we only have simple JSON objects from the root\r\nreference. Complex objects like Map, FormData etc. are stored as their\r\nentries array in the look up and not the complex object. Other complex\r\nobjects like TypedArrays or imports don't have deeply nested objects in\r\nthem that can be referenced.\r\n\r\nThis solves the problem that we only dedupe after the third instance.\r\nThis dedupes at the second instance. It also solves the problem where\r\nall nested objects inside deduped instances also are outlined.\r\n\r\nThe property paths can get pretty large. This is why a test on payload\r\nsize increased. We could potentially outline the reference itself at the\r\nfirst dupe. That way we get a shorter ID to refer to in the third\r\ninstance.","shortMessageHtmlLink":"[Flight] Encode references to existing objects by property path (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2279856062\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/28996\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/28996/hovercard\" href=\"https://github.com/facebook/react/pull/28996\">#28996</a>)"}},{"before":"151cce37401dc2ff609701119d61a17d92fce4ab","after":"c3345638cbb4a53df8151fd9ef106ea018fb5033","ref":"refs/heads/main","pushedAt":"2024-05-09T17:16:08.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"acdlite","name":"Andrew Clark","path":"/acdlite","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3624098?s=80&v=4"},"commit":{"message":"Support useFormStatus in progressively-enhanced forms (#29019)\n\nBefore this change, `useFormStatus` is only activated if a form is\r\nsubmitted by an action function (either `<form action={actionFn}>` or\r\n`<button formAction={actionFn}>`).\r\n\r\nAfter this change, `useFormStatus` will also be activated if you call\r\n`startTransition(actionFn)` inside a submit event handler that is\r\n`preventDefault`-ed.\r\n\r\nThis is the last missing piece for implementing a custom `action` prop\r\nthat is progressively enhanced using `onSubmit` while maintaining the\r\nsame behavior as built-in form actions.\r\n\r\nHere's the basic recipe for implementing a progressively-enhanced form\r\naction. This would typically be implemented in your UI component\r\nlibrary, not regular application code:\r\n\r\n```js\r\nimport {requestFormReset} from 'react-dom';\r\n\r\n// To implement progressive enhancement, pass both a form action *and* a\r\n// submit event handler. The action is used for submissions that happen\r\n// before hydration, and the submit handler is used for submissions that\r\n// happen after.\r\n<form\r\n  action={action}\r\n  onSubmit={(event) => {\r\n    // After hydration, we upgrade the form with additional client-\r\n    // only behavior.\r\n    event.preventDefault();\r\n\r\n    // Manually dispatch the action.\r\n    startTransition(async () => {\r\n      // (Optional) Reset any uncontrolled inputs once the action is\r\n      // complete, like built-in form actions do.\r\n      requestFormReset(event.target);\r\n\r\n      // ...Do extra action-y stuff in here, like setting a custom\r\n      // optimistic state...\r\n\r\n      // Call the user-provided action\r\n      const formData = new FormData(event.target);\r\n      await action(formData);\r\n    });\r\n  }}\r\n/>\r\n```","shortMessageHtmlLink":"Support useFormStatus in progressively-enhanced forms (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2284546837\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29019\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29019/hovercard\" href=\"https://github.com/facebook/react/pull/29019\">#29019</a>)"}},{"before":"3229b97bb538c15c2e849ab5d73d46e5576a105c","after":"732aef73b0e50862673a0a8a5a1cc0e22e0a04c0","ref":"refs/heads/builds/facebook-www","pushedAt":"2024-05-09T16:28:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Track Stack of JSX Calls (#29032)\n\nThis is the first step to experimenting with a new type of stack traces\nbehind the `enableOwnerStacks` flag - in DEV only.\n\nThe idea is to generate stacks that are more like if the JSX was a\ndirect call even though it's actually a lazy call. Not only can you see\nwhich exact JSX call line number generated the erroring component but if\nthat's inside an abstraction function, which function called that\nfunction and if it's a component, which component generated that\ncomponent. For this to make sense it really need to be the \"owner\" stack\nrather than the parent stack like we do for other component stacks. On\none hand it has more precise information but on the other hand it also\nloses context. For most types of problems the owner stack is the most\nuseful though since it tells you which component rendered this\ncomponent.\n\nThe problem with the platform in its current state is that there's two\nways to deal with stacks:\n\n1) `new Error().stack`\n2) `console.createTask()`\n\nThe nice thing about `new Error().stack` is that we can extract the\nframes and piece them together in whatever way we want. That is great\nfor constructing custom UIs like error dialogs. Unfortunately, we can't\ntake custom stacks and set them in the native UIs like Chrome DevTools.\n\nThe nice thing about `console.createTask()` is that the resulting stacks\nare natively integrated into the Chrome DevTools in the console and the\nbreakpoint debugger. They also automatically follow source mapping and\nignoreLists. The downside is that there's no way to extract the async\nstack outside the native UI itself so this information cannot be used\nfor custom UIs like errors dialogs. It also means we can't collect this\non the server and then pass it to the client for server components.\n\nThe solution here is that we use both techniques and collect both an\n`Error` object and a `Task` object for every JSX call.\n\nThe main concern about this approach is the performance so that's the\nmain thing to test. It's certainly too slow for production but it might\nalso be too slow even for DEV.\n\nThis first PR doesn't actually use the stacks yet. It just collects them\nas the first step. The next step is to start utilizing this information\nin error printing etc.\n\nFor RSC we pass the stack along across over the wire. This can be\nconcatenated on the client following the owner path to create an owner\nstack leading back into the server. We'll later use this information to\nrestore fake frames on the client for native integration. Since this\ninformation quickly gets pretty heavy if we include all frames, we strip\nout the top frame. We also strip out everything below the functions that\ncall into user space in the Flight runtime. To do this we need to figure\nout the frames that represents calling out into user space. The\nresulting stack is typically just the one frame inside the owner\ncomponent's JSX callsite. I also eagerly strip out things we expect to\nbe ignoreList:ed anyway - such as `node_modules` and Node.js internals.\n\nDiffTrain build for [151cce37401dc2ff609701119d61a17d92fce4ab](https://github.com/facebook/react/commit/151cce37401dc2ff609701119d61a17d92fce4ab)","shortMessageHtmlLink":"Track Stack of JSX Calls (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2286795890\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29032\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29032/hovercard\" href=\"https://github.com/facebook/react/pull/29032\">#29032</a>)"}},{"before":"34748be60d6d4fa09c525ad67db8aa4920130c49","after":"0952db3456c2483888d17083197c670fbcebde5c","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-05-09T16:28:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Track Stack of JSX Calls (#29032)\n\nThis is the first step to experimenting with a new type of stack traces\nbehind the `enableOwnerStacks` flag - in DEV only.\n\nThe idea is to generate stacks that are more like if the JSX was a\ndirect call even though it's actually a lazy call. Not only can you see\nwhich exact JSX call line number generated the erroring component but if\nthat's inside an abstraction function, which function called that\nfunction and if it's a component, which component generated that\ncomponent. For this to make sense it really need to be the \"owner\" stack\nrather than the parent stack like we do for other component stacks. On\none hand it has more precise information but on the other hand it also\nloses context. For most types of problems the owner stack is the most\nuseful though since it tells you which component rendered this\ncomponent.\n\nThe problem with the platform in its current state is that there's two\nways to deal with stacks:\n\n1) `new Error().stack`\n2) `console.createTask()`\n\nThe nice thing about `new Error().stack` is that we can extract the\nframes and piece them together in whatever way we want. That is great\nfor constructing custom UIs like error dialogs. Unfortunately, we can't\ntake custom stacks and set them in the native UIs like Chrome DevTools.\n\nThe nice thing about `console.createTask()` is that the resulting stacks\nare natively integrated into the Chrome DevTools in the console and the\nbreakpoint debugger. They also automatically follow source mapping and\nignoreLists. The downside is that there's no way to extract the async\nstack outside the native UI itself so this information cannot be used\nfor custom UIs like errors dialogs. It also means we can't collect this\non the server and then pass it to the client for server components.\n\nThe solution here is that we use both techniques and collect both an\n`Error` object and a `Task` object for every JSX call.\n\nThe main concern about this approach is the performance so that's the\nmain thing to test. It's certainly too slow for production but it might\nalso be too slow even for DEV.\n\nThis first PR doesn't actually use the stacks yet. It just collects them\nas the first step. The next step is to start utilizing this information\nin error printing etc.\n\nFor RSC we pass the stack along across over the wire. This can be\nconcatenated on the client following the owner path to create an owner\nstack leading back into the server. We'll later use this information to\nrestore fake frames on the client for native integration. Since this\ninformation quickly gets pretty heavy if we include all frames, we strip\nout the top frame. We also strip out everything below the functions that\ncall into user space in the Flight runtime. To do this we need to figure\nout the frames that represents calling out into user space. The\nresulting stack is typically just the one frame inside the owner\ncomponent's JSX callsite. I also eagerly strip out things we expect to\nbe ignoreList:ed anyway - such as `node_modules` and Node.js internals.\n\nDiffTrain build for commit https://github.com/facebook/react/commit/151cce37401dc2ff609701119d61a17d92fce4ab.","shortMessageHtmlLink":"Track Stack of JSX Calls (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2286795890\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29032\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29032/hovercard\" href=\"https://github.com/facebook/react/pull/29032\">#29032</a>)"}},{"before":"04b058868c9fc61c78124b12efb168734d79d09e","after":"151cce37401dc2ff609701119d61a17d92fce4ab","ref":"refs/heads/main","pushedAt":"2024-05-09T16:23:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sebmarkbage","name":"Sebastian Markbåge","path":"/sebmarkbage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/63648?s=80&v=4"},"commit":{"message":"Track Stack of JSX Calls (#29032)\n\nThis is the first step to experimenting with a new type of stack traces\r\nbehind the `enableOwnerStacks` flag - in DEV only.\r\n\r\nThe idea is to generate stacks that are more like if the JSX was a\r\ndirect call even though it's actually a lazy call. Not only can you see\r\nwhich exact JSX call line number generated the erroring component but if\r\nthat's inside an abstraction function, which function called that\r\nfunction and if it's a component, which component generated that\r\ncomponent. For this to make sense it really need to be the \"owner\" stack\r\nrather than the parent stack like we do for other component stacks. On\r\none hand it has more precise information but on the other hand it also\r\nloses context. For most types of problems the owner stack is the most\r\nuseful though since it tells you which component rendered this\r\ncomponent.\r\n\r\nThe problem with the platform in its current state is that there's two\r\nways to deal with stacks:\r\n\r\n1) `new Error().stack` \r\n2) `console.createTask()`\r\n\r\nThe nice thing about `new Error().stack` is that we can extract the\r\nframes and piece them together in whatever way we want. That is great\r\nfor constructing custom UIs like error dialogs. Unfortunately, we can't\r\ntake custom stacks and set them in the native UIs like Chrome DevTools.\r\n\r\nThe nice thing about `console.createTask()` is that the resulting stacks\r\nare natively integrated into the Chrome DevTools in the console and the\r\nbreakpoint debugger. They also automatically follow source mapping and\r\nignoreLists. The downside is that there's no way to extract the async\r\nstack outside the native UI itself so this information cannot be used\r\nfor custom UIs like errors dialogs. It also means we can't collect this\r\non the server and then pass it to the client for server components.\r\n\r\nThe solution here is that we use both techniques and collect both an\r\n`Error` object and a `Task` object for every JSX call.\r\n\r\nThe main concern about this approach is the performance so that's the\r\nmain thing to test. It's certainly too slow for production but it might\r\nalso be too slow even for DEV.\r\n\r\nThis first PR doesn't actually use the stacks yet. It just collects them\r\nas the first step. The next step is to start utilizing this information\r\nin error printing etc.\r\n\r\nFor RSC we pass the stack along across over the wire. This can be\r\nconcatenated on the client following the owner path to create an owner\r\nstack leading back into the server. We'll later use this information to\r\nrestore fake frames on the client for native integration. Since this\r\ninformation quickly gets pretty heavy if we include all frames, we strip\r\nout the top frame. We also strip out everything below the functions that\r\ncall into user space in the Flight runtime. To do this we need to figure\r\nout the frames that represents calling out into user space. The\r\nresulting stack is typically just the one frame inside the owner\r\ncomponent's JSX callsite. I also eagerly strip out things we expect to\r\nbe ignoreList:ed anyway - such as `node_modules` and Node.js internals.","shortMessageHtmlLink":"Track Stack of JSX Calls (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2286795890\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29032\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29032/hovercard\" href=\"https://github.com/facebook/react/pull/29032\">#29032</a>)"}},{"before":"b1d4096396c1f33cc799d703792cc3f915da8e41","after":"04b058868c9fc61c78124b12efb168734d79d09e","ref":"refs/heads/main","pushedAt":"2024-05-08T17:57:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"kassens","name":"Jan Kassens","path":"/kassens","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11849?s=80&v=4"},"commit":{"message":"Upgrade jest and jsdom (#29026)\n\n## Summary\r\n\r\nThis brings:\r\n - jest* up from 29.4.2 -> 29.7.0\r\n - jsdom up from 20.0.0 -> 22.1.0\r\n\r\nWhile the latest version of jest-dom-environment still wants\r\n`jsdom@^20.0.0`, it can safely use at least up to `jsdom@22.1.0`. See\r\nhttps://github.com/jestjs/jest/pull/13825#issuecomment-1564015010 for\r\ndetails.\r\n\r\nUpgrading to latest versions lets us improve some WheelEvent tests and\r\nwill make it possible to test a much simpler FormData construction\r\napproach (see #29018)\r\n\r\n## How did you test this change?\r\n\r\nRan `yarn test` and `yarn test --prod` successfully","shortMessageHtmlLink":"Upgrade jest and jsdom (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2286110921\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29026\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29026/hovercard\" href=\"https://github.com/facebook/react/pull/29026\">#29026</a>)"}},{"before":"6946ebe620845a0d18e912c9e7ccd4baa0964f1c","after":"b1d4096396c1f33cc799d703792cc3f915da8e41","ref":"refs/heads/main","pushedAt":"2024-05-08T17:37:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"kassens","name":"Jan Kassens","path":"/kassens","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11849?s=80&v=4"},"commit":{"message":"Facebook: merge react index.classic.fb and index.modern.fb (#29025)\n\nFacebook: merge react index.classic.fb and index.modern.fb\r\n\r\nThese export the same.\r\n\r\nNOTE: The 2 builds are still different based on flags and other forked\r\nfiles.","shortMessageHtmlLink":"Facebook: merge react index.classic.fb and index.modern.fb (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2286055774\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29025\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29025/hovercard\" href=\"https://github.com/facebook/react/pull/29025\">#29025</a>)"}},{"before":"1717ab017123cbca9f36238b064e47c4c3259966","after":"6946ebe620845a0d18e912c9e7ccd4baa0964f1c","ref":"refs/heads/main","pushedAt":"2024-05-08T14:52:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"kassens","name":"Jan Kassens","path":"/kassens","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11849?s=80&v=4"},"commit":{"message":"Cleanup enableServerComponentKeys flag (#28743)\n\nCleanup enableServerComponentKeys flag\r\n\r\nFlag is `true` everywhere but RN where it doesn't apply.","shortMessageHtmlLink":"Cleanup enableServerComponentKeys flag (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2225637307\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/28743\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/28743/hovercard\" href=\"https://github.com/facebook/react/pull/28743\">#28743</a>)"}},{"before":"0e6ea6991eef6d1f0d203965c9e4606698fe6944","after":"1717ab017123cbca9f36238b064e47c4c3259966","ref":"refs/heads/main","pushedAt":"2024-05-08T12:26:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hoxyq","name":"Ruslan Lesiutin","path":"/hoxyq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28902667?s=80&v=4"},"commit":{"message":"React DevTools 5.1.0 -> 5.2.0 (#29022)\n\nFull list of changes (not a public changelog):\r\n* fix[react-devtools/ci]: fix configurations for e2e testing\r\n([hoxyq](https://github.com/hoxyq) in\r\n[#29016](https://github.com/facebook/react/pull/29016))\r\n* feat[react-devtools]: display forget badge for components in profiling\r\nsession ([hoxyq](https://github.com/hoxyq) in\r\n[#29014](https://github.com/facebook/react/pull/29014))\r\n* fix[react-devtools]: add backwards compat with legacy element type\r\nsymbol ([hoxyq](https://github.com/hoxyq) in\r\n[#28982](https://github.com/facebook/react/pull/28982))\r\n* Expose \"view source\" options to Fusebox integration\r\n([motiz88](https://github.com/motiz88) in\r\n[#28973](https://github.com/facebook/react/pull/28973))\r\n* Enable inspected element context menu in Fusebox\r\n([motiz88](https://github.com/motiz88) in\r\n[#28972](https://github.com/facebook/react/pull/28972))\r\n* Check in `frontend.d.ts` for react-devtools-fusebox, include in build\r\noutput ([motiz88](https://github.com/motiz88) in\r\n[#28970](https://github.com/facebook/react/pull/28970))\r\n* Devtools: Fix build-for-devtools\r\n([eps1lon](https://github.com/eps1lon) in\r\n[#28976](https://github.com/facebook/react/pull/28976))\r\n* Move useMemoCache hook to react/compiler-runtime\r\n([kassens](https://github.com/kassens) in\r\n[#28954](https://github.com/facebook/react/pull/28954))\r\n* warn -> error for Test Renderer deprecation\r\n([acdlite](https://github.com/acdlite) in\r\n[#28904](https://github.com/facebook/react/pull/28904))\r\n* [react-dom] move all client code to `react-dom/client`\r\n([gnoff](https://github.com/gnoff) in\r\n[#28271](https://github.com/facebook/react/pull/28271))\r\n* Rename the react.element symbol to react.transitional.element\r\n([sebmarkbage](https://github.com/sebmarkbage) in\r\n[#28813](https://github.com/facebook/react/pull/28813))\r\n* Rename Forget badge ([jbonta](https://github.com/jbonta) in\r\n[#28858](https://github.com/facebook/react/pull/28858))\r\n* Devtools: Add support for useFormStatus\r\n([eps1lon](https://github.com/eps1lon) in\r\n[#28413](https://github.com/facebook/react/pull/28413))","shortMessageHtmlLink":"React DevTools 5.1.0 -&gt; 5.2.0 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2285323233\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29022\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29022/hovercard\" href=\"https://github.com/facebook/react/pull/29022\">#29022</a>)"}},{"before":"b37e4b4e616d6d66c1cde9c0a4c2cbd866b0b582","after":"0e6ea6991eef6d1f0d203965c9e4606698fe6944","ref":"refs/heads/main","pushedAt":"2024-05-08T12:16:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hoxyq","name":"Ruslan Lesiutin","path":"/hoxyq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28902667?s=80&v=4"},"commit":{"message":"fix[react-devtools/InspectedElementView.css]: dont draw bottom border for empty badge list (#29023)\n\nForward fix to https://github.com/facebook/react/pull/29014, the bug was\r\ndiscovered while testing v5.2.0.","shortMessageHtmlLink":"fix[react-devtools/InspectedElementView.css]: dont draw bottom border…"}},{"before":"acdffc09bd21677f8784af1f92e735ed32d2d692","after":"34748be60d6d4fa09c525ad67db8aa4920130c49","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-05-08T12:14:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Clean up fastAddProperties and make it more correct (#29015)\n\n## Summary\n\nThis PR makes some fixes to the `fastAddProperties` function:\n- Use `if (!attributeConfig)` instead of `if (attributeConfig ===\nundefined)` to account for `null`.\n- If a prop has an Object `attributeConfig` with a `diff` function\ndefined on it, treat it as an atomic value to keep the semantics of\n`diffProperties`.\n\n## How did you test this change?\n\nBuild and run RNTester app.\n\nDiffTrain build for commit https://github.com/facebook/react/commit/b37e4b4e616d6d66c1cde9c0a4c2cbd866b0b582.","shortMessageHtmlLink":"Clean up fastAddProperties and make it more correct (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2283226576\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29015\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29015/hovercard\" href=\"https://github.com/facebook/react/pull/29015\">#29015</a>)"}},{"before":"e150a324259c5c63ab635b227f601052b133a99f","after":"b37e4b4e616d6d66c1cde9c0a4c2cbd866b0b582","ref":"refs/heads/main","pushedAt":"2024-05-08T12:10:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"dmytrorykun","name":"Dmytro Rykun","path":"/dmytrorykun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14206200?s=80&v=4"},"commit":{"message":"Clean up fastAddProperties and make it more correct (#29015)\n\n## Summary\r\n\r\nThis PR makes some fixes to the `fastAddProperties` function:\r\n- Use `if (!attributeConfig)` instead of `if (attributeConfig ===\r\nundefined)` to account for `null`.\r\n- If a prop has an Object `attributeConfig` with a `diff` function\r\ndefined on it, treat it as an atomic value to keep the semantics of\r\n`diffProperties`.\r\n\r\n## How did you test this change?\r\n\r\nBuild and run RNTester app.","shortMessageHtmlLink":"Clean up fastAddProperties and make it more correct (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2283226576\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29015\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29015/hovercard\" href=\"https://github.com/facebook/react/pull/29015\">#29015</a>)"}},{"before":"ec15267a001086deb4ab5412d3f8b7e13573d6a5","after":"e150a324259c5c63ab635b227f601052b133a99f","ref":"refs/heads/main","pushedAt":"2024-05-08T11:04:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hoxyq","name":"Ruslan Lesiutin","path":"/hoxyq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28902667?s=80&v=4"},"commit":{"message":"fix[react-devtools/ci]: fix configurations for e2e testing (#29016)\n\nThis should fix failing DevTools e2e tests on `main`.\r\n\r\nWith these changes, running tests locally successfully passes all cases.","shortMessageHtmlLink":"fix[react-devtools/ci]: fix configurations for e2e testing (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2283599649\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29016\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29016/hovercard\" href=\"https://github.com/facebook/react/pull/29016\">#29016</a>)"}},{"before":"e83564ae448640ab0d1dceb2ff6f3a4b8476b480","after":"3229b97bb538c15c2e849ab5d73d46e5576a105c","ref":"refs/heads/builds/facebook-www","pushedAt":"2024-05-08T02:24:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"[Flight Reply] Resolve outlined models async in Reply just like in Flight Client (#28988)\n\nThis is the same change as #28780 but for the Flight Reply receiver.\n\nWhile it's not possible to create an \"async module\" reference in this\ncase - resolving a server reference can still be async if loading it\nrequires loading chunks like in a new server instance.\n\nSince extracting a typed array from a Blob is async, that's also a case\nwhere a dependency can be async.\n\nDiffTrain build for [ec15267a001086deb4ab5412d3f8b7e13573d6a5](https://github.com/facebook/react/commit/ec15267a001086deb4ab5412d3f8b7e13573d6a5)","shortMessageHtmlLink":"[Flight Reply] Resolve outlined models async in Reply just like in Fl…"}},{"before":"6bac4f2f31378cd58dffe6181e00639366a6081a","after":"ec15267a001086deb4ab5412d3f8b7e13573d6a5","ref":"refs/heads/main","pushedAt":"2024-05-08T02:19:59.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sebmarkbage","name":"Sebastian Markbåge","path":"/sebmarkbage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/63648?s=80&v=4"},"commit":{"message":"[Flight Reply] Resolve outlined models async in Reply just like in Flight Client (#28988)\n\nThis is the same change as #28780 but for the Flight Reply receiver.\r\n\r\nWhile it's not possible to create an \"async module\" reference in this\r\ncase - resolving a server reference can still be async if loading it\r\nrequires loading chunks like in a new server instance.\r\n\r\nSince extracting a typed array from a Blob is async, that's also a case\r\nwhere a dependency can be async.","shortMessageHtmlLink":"[Flight Reply] Resolve outlined models async in Reply just like in Fl…"}},{"before":"86893d48318e20af39230321517e87f6f9a6a83d","after":"e83564ae448640ab0d1dceb2ff6f3a4b8476b480","ref":"refs/heads/builds/facebook-www","pushedAt":"2024-05-08T01:58:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"[Flight Reply] Encode binary streams as a single collapsed Blob (#28986)\n\nBased on #28893.\n\nFor other streams we encode each chunk as a separate form field which is\na bit bloated. Especially for binary chunks since they also have an\nindirection. We need some way to encode the chunks as separate anyway.\nThis way the streaming using busboy actually allows each chunk to stream\nin over the network one at a time.\n\nFor binary streams the actual chunking is not important. The chunks can\nbe split and recombined in whatever size chunk makes sense.\n\nSince we buffer the entire content anyway we can combine the chunks to\nbe consecutive. This PR does that with binary streams and also combine\nthem into a single Blob. That way there's no extra overhead when passing\nthrough a binary stream.\n\nIdeally, we'd be able to just use the stream from that one Blob but\nNode.js doesn't return byob streams from Blob. Additionally, we don't\nactually stream the content of Blobs due to the layering with busboy\natm. We could do that for binary streams in particular by replacing the\nFile layering with a stream and resolving each chunk as it comes in.\nThat could be a follow up.\n\nIf we stop buffering in the future, this set up still allows us to split\nthem and send other form fields in between while blocked since the\nprotocol is still the same.\n\nDiffTrain build for [826bf4e51ecf14904e936ed043392084553ebbaa](https://github.com/facebook/react/commit/826bf4e51ecf14904e936ed043392084553ebbaa)","shortMessageHtmlLink":"[Flight Reply] Encode binary streams as a single collapsed Blob (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2278231442\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/28986\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/28986/hovercard\" href=\"https://github.com/facebook/react/pull/28986\">#28986</a>)"}},{"before":"7e3000e0527a12e462427a95dfee45ca6a0a6b2c","after":"86893d48318e20af39230321517e87f6f9a6a83d","ref":"refs/heads/builds/facebook-www","pushedAt":"2024-05-08T01:58:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"[Fizz] Fallback to client replaying actions if we're trying to serialize a Blob (#28987)\n\nThis follows the same principle as in #28611.\n\nWe cannot serialize Blobs of a form data into HTML because you can't\ninitialize a file input to some value. However the serialization of\nstate in an Action can contain blobs. In this case we do error but\noutside the try/catch that recovers to error to client replaying instead\nof MPA mode. This errors earlier to ensure that this works.\n\nTesting this is a bit annoying because JSDOM doesn't have any of the\nBlob methods but the Blob needs to be compatible with FormData and the\nFormData needs to be compatible with `<form>` nodes in these tests. So I\npolyfilled those in JSDOM with some hacks.\n\nA possible future enhancement would be to encode these blobs in a base64\nmode instead and have some way to receive them on the server. It's just\na matter of layering this. I think the RSC layer's `FORM_DATA`\nimplementation can pass some flag to encode as base64 and then have\ndecodeAction include some way to parse them. That way this case would\nwork in MPA mode too.\n\nDiffTrain build for [6bac4f2f31378cd58dffe6181e00639366a6081a](https://github.com/facebook/react/commit/6bac4f2f31378cd58dffe6181e00639366a6081a)","shortMessageHtmlLink":"[Fizz] Fallback to client replaying actions if we're trying to serial…"}},{"before":"826bf4e51ecf14904e936ed043392084553ebbaa","after":"6bac4f2f31378cd58dffe6181e00639366a6081a","ref":"refs/heads/main","pushedAt":"2024-05-08T01:53:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sebmarkbage","name":"Sebastian Markbåge","path":"/sebmarkbage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/63648?s=80&v=4"},"commit":{"message":"[Fizz] Fallback to client replaying actions if we're trying to serialize a Blob (#28987)\n\nThis follows the same principle as in #28611.\r\n\r\nWe cannot serialize Blobs of a form data into HTML because you can't\r\ninitialize a file input to some value. However the serialization of\r\nstate in an Action can contain blobs. In this case we do error but\r\noutside the try/catch that recovers to error to client replaying instead\r\nof MPA mode. This errors earlier to ensure that this works.\r\n\r\nTesting this is a bit annoying because JSDOM doesn't have any of the\r\nBlob methods but the Blob needs to be compatible with FormData and the\r\nFormData needs to be compatible with `<form>` nodes in these tests. So I\r\npolyfilled those in JSDOM with some hacks.\r\n\r\nA possible future enhancement would be to encode these blobs in a base64\r\nmode instead and have some way to receive them on the server. It's just\r\na matter of layering this. I think the RSC layer's `FORM_DATA`\r\nimplementation can pass some flag to encode as base64 and then have\r\ndecodeAction include some way to parse them. That way this case would\r\nwork in MPA mode too.","shortMessageHtmlLink":"[Fizz] Fallback to client replaying actions if we're trying to serial…"}},{"before":"e7d213dfb0760dc9f6506fca6d6cfbac708a40e2","after":"826bf4e51ecf14904e936ed043392084553ebbaa","ref":"refs/heads/main","pushedAt":"2024-05-08T01:52:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sebmarkbage","name":"Sebastian Markbåge","path":"/sebmarkbage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/63648?s=80&v=4"},"commit":{"message":"[Flight Reply] Encode binary streams as a single collapsed Blob (#28986)\n\nBased on #28893.\r\n\r\nFor other streams we encode each chunk as a separate form field which is\r\na bit bloated. Especially for binary chunks since they also have an\r\nindirection. We need some way to encode the chunks as separate anyway.\r\nThis way the streaming using busboy actually allows each chunk to stream\r\nin over the network one at a time.\r\n\r\nFor binary streams the actual chunking is not important. The chunks can\r\nbe split and recombined in whatever size chunk makes sense.\r\n\r\nSince we buffer the entire content anyway we can combine the chunks to\r\nbe consecutive. This PR does that with binary streams and also combine\r\nthem into a single Blob. That way there's no extra overhead when passing\r\nthrough a binary stream.\r\n\r\nIdeally, we'd be able to just use the stream from that one Blob but\r\nNode.js doesn't return byob streams from Blob. Additionally, we don't\r\nactually stream the content of Blobs due to the layering with busboy\r\natm. We could do that for binary streams in particular by replacing the\r\nFile layering with a stream and resolving each chunk as it comes in.\r\nThat could be a follow up.\r\n\r\nIf we stop buffering in the future, this set up still allows us to split\r\nthem and send other form fields in between while blocked since the\r\nprotocol is still the same.","shortMessageHtmlLink":"[Flight Reply] Encode binary streams as a single collapsed Blob (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2278231442\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/28986\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/28986/hovercard\" href=\"https://github.com/facebook/react/pull/28986\">#28986</a>)"}},{"before":"cd43d60b044dbad6aabad18c8891a7b5540a5e04","after":null,"ref":"refs/heads/rename_forget_badge","pushedAt":"2024-05-07T17:08:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"kassens","name":"Jan Kassens","path":"/kassens","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11849?s=80&v=4"}},{"before":"c32ff0f4f196cb1fbfdb93a6f08c60b27fc7f31c","after":"e7d213dfb0760dc9f6506fca6d6cfbac708a40e2","ref":"refs/heads/main","pushedAt":"2024-05-07T15:39:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hoxyq","name":"Ruslan Lesiutin","path":"/hoxyq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28902667?s=80&v=4"},"commit":{"message":"feat[react-devtools]: display forget badge for components in profiling session (#29014)\n\n# Summary\r\n- `compiledWithForget` field for nodes is now propagated from the\r\nbackend to frontend profiler stores\r\n- Corresponding node with such field will have a `✨` prefix displayed\r\nbefore its displayName\r\n<img width=\"1728\" alt=\"Screenshot 2024-05-07 at 15 05 37\"\r\nsrc=\"https://github.com/facebook/react/assets/28902667/fe044d40-52cb-4169-867d-5a2d72e3275b\">\r\n\r\n- Badges are now displayed on the right panel when some fiber is\r\nselected in a specific commit\r\n<img width=\"1728\" alt=\"Screenshot 2024-05-07 at 15 05 50\"\r\nsrc=\"https://github.com/facebook/react/assets/28902667/297ba5ca-404d-4172-b9bf-bfed7978afe5\">\r\n\r\n- Badges are also displayed when user hovers over some node in the tree\r\n<img width=\"1728\" alt=\"Screenshot 2024-05-07 at 15 25 22\"\r\nsrc=\"https://github.com/facebook/react/assets/28902667/bee47884-61d1-46b6-a483-717fc148893a\">","shortMessageHtmlLink":"feat[react-devtools]: display forget badge for components in profilin…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAERp1ZSgA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/react"}