-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ambiguity on why the index property in ViewToken is marked optional #3637
Comments
👋 Hey there, it looks like there has been no activity on this issue in the last 90 days. Has the issue been fixed, or does it still require the community attention? This issue will be closed in the next 7 days if no further activity occurs. Thank you for your contributions. |
No response yet so it would not consider this "fixed". (Just commenting so the issue will stay open, as it should) |
@pedropbazzo please see my comment on your PR. I don't think it solves this issue. |
Description
On the ViewToken page in the docs it shows that the
index
property is optional. This is not explained in any further detail by the docs.What is the problem?
It is unclear to me in what situation this property would be
null
. This object is used as a parameter for theonViewableItemsChanged
callback inVirtualizedList
so it is in turn also used in bothFlatList
andSectionList
. This makes me think there wouldn't be a situation whereindex
would benull
.How can we address it?
Update the description of the
index
property onViewToken
to clarify in what situation it could benull
.If anyone knows a resource like an issue in the react-native repo or a from post that discusses this or can explain it to me I can also make a PR to clarify the description on the property.
Why is it important?
It is currently ambiguous why the
index
property onViewToken
is marked as optional.Who needs this?
Anyone using the
onViewableItemsChanged
prop and relies on the indexes of the callback.The text was updated successfully, but these errors were encountered: