Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy dependency version needs to be bumped to 1.20.x for numpy.typing #2563

Open
winedarksea opened this issue Mar 20, 2024 · 0 comments
Open

Comments

@winedarksea
Copy link
Contributor

Or else the typing import needs to be removed (it isn't strictly necessary for any functionality).

I can open a PR for this, it's pretty simple, but I think someone needs to answer the question of whether a dependency version bump or the need for typing is more important.

from numpy.typing import NDArray

on np<1.20, an error occurs, module not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant