-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forecaster.preprocess() may introduce unwanted behavior for NaN history values in 1.1.5 #2518
Comments
Thanks for noticing this! It makes sense that we'd want predictions for missing |
Hey @tcuongd, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have noticed that the changes made to this line may introduce unwanted behavior in the future dataframe:
prophet/python/prophet/forecaster.py
Line 1133 in c00f6a2
This will make
make_future_dataframe()
ignore the dates with NaN values in the history, consideringin the versions prior to 1.1.5 (for reference):
Notice that the dataframe
df['ds'].unique()
is used instead of the not nullhistory['ds'].unique()
The text was updated successfully, but these errors were encountered: