Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: defer watch until the initial processing of list is complete #6004

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: defer watch until the initial processing of list is complete #6004

merged 1 commit into from
May 21, 2024

Conversation

shawkins
Copy link
Contributor

Description

closes: #5953

Provides a callback to ProcessorStore.retainAll so that we can defer starting the watch in some circumstances. Not really a bug, just makes testing / behavior more predictable.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

manusa
manusa requested changes May 20, 2024
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReflectorTest is not starting, I guess the changes in the behavior prevent the tests from start.

I've tried to look into it, but the test contains many mocks and I don't really know the internals about them.

@shawkins
Copy link
Contributor Author

I've tried to look into it, but the test contains many mocks and I don't really know the internals about them.

Should be good now.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@manusa manusa added this to the 6.13.0 milestone May 21, 2024 — with automated-tasks
manusa
manusa approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit c470c55 into fabric8io:main May 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia rohanKanojia is a code owner

@sunix sunix Awaiting requested review from sunix sunix is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.13.0
Development

Successfully merging this pull request may close these issues.

ResourceListTest.testCreateOrReplaceWithDeleteExisting flakiness
2 participants
@shawkins @manusa