Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalisition #54

Open
faboweb opened this issue Jun 26, 2017 · 2 comments
Open

Internationalisition #54

faboweb opened this issue Jun 26, 2017 · 2 comments

Comments

@faboweb
Copy link
Contributor

faboweb commented Jun 26, 2017

@fokusferit @fragsalat @tonysaad and me decided to go with following approach for internationalisation:

Each component that uses localisable labels has a property lang that takes in a language identifier.
The language can be chosen in the WS-Header. There is an language-changed-event propagated by the WS-Header the dev can listen on.
The localised labels are stored in a json per component.
The currency- and date-format are affected by this language property.
The default is always german ('de').
Both currency- and date-format can be overwritten by the properties currency-format and date-format.

@schluchter
Copy link
Contributor

Clarification: The currency format is affected by the localization, but not the currency itself, right? Just to be explicit: If the currency changed based on my settings, that would be a disaster.

@fragsalat
Copy link
Contributor

First of all. This is absolutely not urgent and critical since we have not that many texts in our components. Secondly you are right. The currency itself remains the same and is decided by the data the application inserts into the components. The difference is how numbers are displayed (comma or dot for thousands) where the currency is placed and general words such as Wednesday, Choose and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants