Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of Erased types #2914

Open
alfonsogarciacaro opened this issue Jun 1, 2022 · 1 comment · May be fixed by #3282
Open

Type of Erased types #2914

alfonsogarciacaro opened this issue Jun 1, 2022 · 1 comment · May be fixed by #3282

Comments

@alfonsogarciacaro
Copy link
Member

alfonsogarciacaro commented Jun 1, 2022 •
edited

Right now any type decorated with Erase becomes Any in Fable AST. This makes sense because originally Erase was thought for erased unions representing Typescript unions. However now there are cases where we want to erase the declaration but not necessarily the type.

Another use case is when using a union just to wrap a primitive, then it should probably become the type of the primitive (although I'm not sure if Fable users frequently do this).
@alfonsogarciacaro alfonsogarciacaro mentioned this issue Jun 13, 2022
Open
@dbrattli
Copy link
Collaborator

Yes, this would be really nice for Python if it was possible. E.g for the example:

let fn (a: U2<string, int>) =
    ()

It's currently translated to:

def fn(a: Any=None) -> None:
    pass

I would like to transpile this to become:

def fn(a: Tuple[str, int]) -> None:
    pass

This was referenced Nov 20, 2022
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable erase unions with tags fable-compiler/Fable
2 participants
@dbrattli @alfonsogarciacaro