Added TypeScript support for $.fn #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Although In such a rare case, the TypeScript users shall do |
Added TypeScript support for $.fn `[key: string]: Function;` is added to `Cash` such that fabiospampinato#380 can be resolved. `ArrayLike<HTMLElement>` is also added such that Cash can be array-like with HTMLElement results from `querySelectorAll`. The element array shall be the normal use for this script. If the array content is other type such as document, window, number, etc, for typescript users, they shall do `$(document)[0] as any as Document`.
cyfung1031
force-pushed
the
patch-typescript-cash.fn
branch
from
dc4d3cf
to
4499af7
Compare
[key: string]: Function;This seems just incorrect, so I don't think it belongs. class Cash implements ArrayLike<HTMLElement> {This is I guess kinda true, except maybe we should use |
|
PR closed as the change should be in Interface Cash not class Cash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #380; resolves #421
[key: string]: Function;is added toCashsuch that #380 can be resolved.ArrayLike<HTMLElement>is also added such that Cash can be array-like withHTMLElementresults fromquerySelectorAll.