Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database::create_edge_collection creates regular document collection #26

Closed
theduke opened this issue Jul 25, 2020 · 5 comments · Fixed by #112
Closed

Database::create_edge_collection creates regular document collection #26

theduke opened this issue Jul 25, 2020 · 5 comments · Fixed by #112

Comments

@theduke
Copy link
Contributor

theduke commented Jul 25, 2020

Title says it all.

Unexpectedly, a regular document collection is created.
@fMeow
Copy link
Owner

fMeow commented Jul 26, 2020

Thanks to your PR(#27), it should be fixed now. I also add a minimal e2e test to ensure the create_edge_collection performs correctly.

@theduke theduke closed this as completed Jul 26, 2020
@theduke
Copy link
Contributor Author

theduke commented Jul 26, 2020 •
edited

Great.

Due to the complexity of the API, it might be worthwile to investigate auto-generating base code from the official Swagger/OpenAPI specification, and then providing a nicer API on top.

I don't think the current OpenAPI Rust code generators are of great quality though...

@arn-the-long-beard
Copy link
Contributor

Hello, thank you for your work !!!

@TroyKomodo
Copy link
Contributor

I think this is broken again.
@fMeow

@fMeow fMeow reopened this May 22, 2024
@TroyKomodo
Copy link
Contributor

Looking at the code it seems that the server expects an integer but the code serializes a string for the fields.

Perhaps using serde_repr rather than just aliasing the fields to 1 or 2.

TroyKomodo added a commit to TroyKomodo/arangors that referenced this issue May 25, 2024
@TroyKomodo
fix: integer enum type serialization
8bd02af 
Use serde repr to serialize and deserialize the integer enum types.

fixes fMeow#26
@TroyKomodo TroyKomodo mentioned this issue May 25, 2024
Merged
@fMeow fMeow closed this as completed in #112 Jun 6, 2024
fMeow pushed a commit that referenced this issue Jun 6, 2024
@TroyKomodo
fix: integer enum type serialization (#112)
2fb9fa8 
Use serde repr to serialize and deserialize the integer enum types.

fixes #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: integer enum type serialization TroyKomodo/arangors
4 participants
@theduke @fMeow @arn-the-long-beard @TroyKomodo